chore: remove legacy requirements.txt - #122
Merged
Merged
Conversation
pyproject.toml has been the source of truth since 13bd56f ("Transitioned to pyproject.toml"). Nothing in the repo reads requirements.txt: the README instructs `uv sync`, the Dockerfile does `pip install -e .`, and no script or notebook references it. It has also drifted from pyproject.toml (scanreader points at atlab/ instead of the BrainCOGS/ fork, icalevents is missing), so keeping it around only invites installing the wrong set. Assisted-by: ClaudeCode:claude-opus-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Human guided, AI assisted PR (using this skill). AI text below. 🤖
What changed
Deletes
requirements.txt. Split out of #120 (Dependabot config), which deliberately omitted apipecosystem for this file.Why
pyproject.tomlhas been the source of truth since 13bd56f ("Transitioned to pyproject.toml"), withuv.lockalongside it.uv sync, theDockerfilerunspip install -e ., andgrep -rn requirementsover the repo (excluding.git,.venv,uv.lock) finds no reference to it in any script, notebook, or config.pyproject.toml:scanreaderpoints atatlab/scanreaderinstead of theBrainCOGS/scanreaderfork used in[project.optional-dependencies].pipeline,icaleventsis absent, and it has no version floors. Anyone who doespip install -r requirements.txtgets a different environment than the one the package declares.pipentry, so it would silently go stale forever.If a flat pin list is ever needed (e.g. for a non-uv deployment),
uv export --format requirements-txtregenerates one from the lock.Verification
git grep -n "requirements.txt"on this branch: no matches.uv sync --lockedis unaffected (the file isn't an input to the lock).Assisted-by: ClaudeCode:claude-opus-5