P1B: Refactor (packages/server/src/handlers/session.ts): Found 18 lines of identical code in 2 locations (mass = 71) - #190
Open
yamj6 wants to merge 3 commits into
Open
P1B: Refactor (packages/server/src/handlers/session.ts): Found 18 lines of identical code in 2 locations (mass = 71)#190yamj6 wants to merge 3 commits into
yamj6 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P1B: Starter Task: Refactoring PR
Use this pull request template to briefly answer the questions below in one to two sentences each.
Feel free to delete this text at the top after filling out the template.
1. Issue
Link to the associated GitHub issue:
#163
Full path to the refactored file:
https://github.com/yamj6/opencode/blob/qltysmell/packages/server/src/handlers/session.ts
What do you think this file does?
(Your answer does not have to be 100% correct; give a reasonable, evidence‑based guess.)
I think this code handles session creation, model/agent switching, compacting, waiting, etc based on the yield lines.
What is the scope of your refactoring within that file?
(Name specific functions/blocks/regions touched.)
The session.compact and session.wait handle inside the SessionHandler.
Which Qlty‑reported issue did you address?
(Name the rule/metric and include the BEFORE value; e.g., “Cognitive Complexity 18 in render()”.)
Found 18 lines of identical code in 2 locations (mass=71)
2. Refactoring
How did the specific issue you chose impact the codebase’s maintainability?
Having identical lines of code in multiple places creates difficulty for the developer in the case where they want to make changes. They would have to rewrite the change however many times the code is repeated and there is a chance that they miss rewriting the change.
What changes did you make to resolve the issue?
I created a mapSessionNotFound helper that is reused through Effect.catchTag.
How do your changes improve maintainability? Did you consider alternatives?
This reduces duplication, and future changes that lead to any error messages only need to be changed once.
3. Validation
How did you validate that the change is correct?
Attach a screenshot of the test coverage showing the lines were executed by the tests.
Attach a screenshot showing the tests that cover the change passing during CI
Attach a screenshot of
qlty smells --no-snippets <full/path/to/file.ts>showing fewer reported issues after the changes.