Repository navigation
Improve shared site structure, content loading and accessibility - #35
Merged
Merged
Conversation
Code quality: memoize build-time content loaders, add path-contextual error reporting and required-key shape assertions, remove dead markdown helpers, guard the collection sort comparator, share one SiteData type, validate calendar statuses at load, extend the image-reference check to styles/*.css, harden serve.mjs path resolution, consolidate the thirteen identical root layouts into one (site) route-group layout, extract a shared JournalCard and reformat single-line page JSX. UI/UX: restore the saved theme before first paint via a blocking inline head script, add a branded not-found page, move the calendar single-column breakpoint to 1000px, inert content/footer and close on outside pointer or focus loss while the mobile menu is open, give whole-card links concise accessible names, switch activity filters to radio semantics with a result-count announcement, focus the calendar dates region only when it scrolls, keep promoted:false member pages out of the sitemap, add meta descriptions to detail and Contact pages, action-labelled theme toggle, content-driven header/footer menus via menus.yml, ui.yml keys for calendar aria labels and open seats, a no-JS calendar notice, and announce event details only after explicit selection. DESIGN.md and the change record are updated per the design contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This branch improves content loading, shared templates and site accessibility. It includes the original review commits and a follow-up review that fixes regressions found in their implementation.
Validation
npm run buildpassed on Windows / Node 24.19.0: design guard, 20 image references, 11 calendar tests, 3 content-loader tests, TypeScript/static export, 21 redirect stubs and 2 post-export checks.Findings, screenshots and limitations:
docs/design/code-quality-review-2026-10-19.md.Owner preview gate
Preview is running at http://localhost:4102/. Owner testing/approval of this implementation and the Build Next.js site (no deploy) check are required before squash merge. This PR does not claim publication or live verification.