[ENG-12073] New ORCiD SSO authentication flow between OSF and CAS - #117
Merged
cslzchen merged 6 commits intoSep 2, 2026
Conversation
cslzchen
marked this pull request as draft
August 28, 2026 17:57
cslzchen
marked this pull request as ready for review
August 31, 2026 20:40
cslzchen
changed the title
Contributor
Author
|
Note: don't squash merge because we want to preserve the "WAR-Overlay" diff: 47f0be6 |
cslzchen
commented
Sep 2, 2026
cslzchen
left a comment
cslzchen
left a comment
Contributor
Author
There was a problem hiding this comment.
Update: will handle the rest in a different PR, merging this into the feature branch so we can dev-test and debug it on staging1.
Comment on lines
+46
to
+49
| if (StringUtils.isNoneBlank(refreshToken)) { | ||
| logger.debug("add refresh_token: {} to profile", token); | ||
| profile.addAttribute(REFRESH_TOKEN, refreshToken); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Comment for easy reference: I "WAR Overlay"ed org.pac4j.oauth.profile.creator.OAuth20ProfileCreator to add refresh token to profile attributes.
cslzchen
merged commit Sep 2, 2026
85ffa8e
into
CenterForOpenScience:feature/orcid-rework
1 check passed
cslzchen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
ENG-12073
Purpose
New ORCiD SSO authentication flow between OSF and CAS (after
apereoandpac4jhas handled OAuth between CAS and ORCiD)It releases access token and refresh token to OSF after successful ORCiD SSO
The following will be done in a follow-up PR:
POC: Rewrite ORCiD SSO to use OSF credentials and flow and release access token to OSFThis is a temporary PoC implementation (with debugging logs) that let ORCiD SSO use OSF's credential/authentication flow.Need to move this to its own credential/authentication flow for the full implementation.Changes
See diff
Dev Notes
See ticket
QA Notes
See ticket
Dev-Ops Notes
See ticket