Skip to content

Upgrade nose - #276

Merged
kylegibson-rldatix merged 2 commits into
masterfrom
issue_276
Oct 30, 2026
Merged

kylegibson-rldatix merged 2 commits into
masterfrom
issue_276

Conversation

@kylegibson-rldatix

Copy link
Copy Markdown
Collaborator

Upgrade from nose 1.3.0 to 1.3.7 for python < 3.7 and switch to pynose for 3.7+

@kylegibson-rldatix kylegibson-rldatix self-assigned this Oct 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Both testing requirements files still pin nose to 1.3.0 for Python < 3.7, leaving those installations without the intended 1.3.7 upgrade.

1 open issue
What changed in this PR

This PR updates test-runner dependencies to select nose or pynose based on the Python version.

Changes:

  • Restricts nose to Python versions below 3.7.
  • Adds pynose 1.5.5 for Python 3.7 and later in both testing requirements files.
File Description
requirements/​testing.txt Adds Python-version-based test-runner selection to testing dependencies.
requirements/​testing-base.txt Applies the same test-runner selection to base testing dependencies.

Review effort: Balanced

Comment thread requirements/testing.txt Resolved

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the Python-version-specific test runner dependency updates.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@kylegibson-rldatix
kylegibson-rldatix merged commit 20c6fdc into master Oct 30, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants