Repository navigation
Upgrade nose - #276
Merged
Merged
Upgrade nose#276
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Both testing requirements files still pin nose to 1.3.0 for Python < 3.7, leaving those installations without the intended 1.3.7 upgrade.
1 open issue
What changed in this PR
This PR updates test-runner dependencies to select nose or pynose based on the Python version.
Changes:
- Restricts nose to Python versions below 3.7.
- Adds pynose 1.5.5 for Python 3.7 and later in both testing requirements files.
| File | Description |
|---|---|
| requirements/testing.txt | Adds Python-version-based test-runner selection to testing dependencies. |
| requirements/testing-base.txt | Applies the same test-runner selection to base testing dependencies. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Upgrade from nose 1.3.0 to 1.3.7 for python < 3.7 and switch to pynose for 3.7+