Skip to content

os.path.join creates malformed URLs on Windows #373

Description

@BenediktHeinrichs

We are currently trying to run waterbutler on Windows and on inspection of the registered routes, we stumbled upon the following line in app.py:

(os.path.join('/', api.PREFIX, pattern.lstrip('/')), handler)

This has a strange behavior on Windows, so that instead of a normal "/" it adds a "\", which makes the api v1 not useable on Windows.

One workaround we implemented was to just add those three strings manually using the following line:

('/' + api.PREFIX + '/' + pattern.lstrip('/'), handler)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions