feat: opt-in create_if_not_exists for concurrent table creation - #722
Open
JoepBeurskens wants to merge 7 commits into
Open
JoepBeurskens wants to merge 7 commits into
JoepBeurskens wants to merge 7 commits into
Conversation
…o prevent table creation collisions
|
JoepBeurskens seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit f0520d5. Configure here.
…y/no-catchup path
…void empty query)
koletzilla
requested review from
koletzilla
and
a balanced review from Copilot
August 27, 2026 12:55
Contributor
There was a problem hiding this comment.
Pull request overview
Adds opt-in atomic table creation intended to mitigate concurrent first-creation races.
Changes:
- Adds
create_if_not_existsSQL generation and compatibility checks. - Adds integration coverage for enabled and default behavior.
- Documents the feature in the changelog.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
table.sql |
Implements atomic conditional table creation. |
test_create_if_not_exists.py |
Tests generated SQL and row counts. |
CHANGELOG.md |
Adds the user-facing feature entry. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…d tests for exercises two dbt invocations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fixes #721. See CHANGELOG. Adds an opt-in
create_if_not_exists modelconfig; default off; not for Replicated engines.Checklist
Delete items not relevant to your PR: