fix: apply column codec and ttl to distributed tables - #741
Open
Romano-arist wants to merge 8 commits into
Open
Romano-arist wants to merge 8 commits into
Romano-arist wants to merge 8 commits into
Conversation
…y; ttl stays local-only
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 2b57093. Configure here.
…umn-codec-ttl # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Column-level
codecandttlwere ignored fordistributed_incrementalmodels: they were not applied on table create, and on schema changes onlycodecwas applied (neverttl). This fixes both paths so columncodec/ttlfrom the model contract are applied on create and on add/modify column.Limitations and out of scope for this PR
Checklist