Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 2 | Book-library by Tobias-Amaechina · Pull Request #516 · CodeYourFuture/Module-Data-Flows

Tobias-Amaechina · 2026-08-05T22:15:31Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Corrected validation logic to ensure title, author, and pages fields are required before adding a book.

Fixed bug where the author field was ignored and replaced with the title value.

Corrected array reference (library → myLibrary) to prevent runtime errors when adding books.

Repaired table‑rendering loop by fixing a missing parenthesis in the row‑deletion logic.

Corrected read/unread status logic so check === true displays “Yes”.

Fixed delete‑button creation:

Corrected variable name (delButton instead of delBut)

Removed accidental reassignment of the button element

Corrected event listener from "clicks" to "click"

Ensured delete action removes the correct book and re-renders the table

…ssed twice

cjyuan

Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

Tobias-Amaechina · 2026-08-10T13:44:36Z

Thank you CY for the link , it definitely helped and the HTML has been validated , Thanks

…ings.json file

cjyuan

Changes look good.

I only have a few more possible improvements for you to consider.

cjyuan · 2026-08-11T09:22:37Z

          value="Submit"
          class="btn btn-primary"
-          onclick="submit();"
+          onclick="handleSubmit();"


Suggestion: Look up the trade-off among different approaches for attaching event listener to HTML elements. In particulars,

Via HTML attribute in HTML

In JS, using .addEventListener()

cjyuan · 2026-08-11T09:24:28Z

-    let book = new Book(title.value, title.value, pages.value, check.checked);
-    library.push(book);
-    render();
+  if (!title || !author || !pages || pages <= 0) {


What type of number should pages be? Could it be NaN?

Although the HTML is prepared to reject non positive whole number, it is a safer practice to also fully check the input in JS code to ensure it is a positive whole number.

…hole number

…t element

…stener below it

cjyuan

Changes look good.

cjyuan · 2026-08-12T11:51:27Z

@@ -62,13 +65,13 @@ <h1>Library</h1>
          />Read
        </label>


Did you notice the checkbox is not showing in the form?
The issue is related to Bootstrap 4.4.1 and AI can point out a solution if you show the code to it (and mention the code uses Bootstrap 4.4.1)

Fixing this is optional.

cjyuan · 2026-08-12T11:57:34Z

 }

+// attach listener 
+document.getElementById("submit-btn").addEventListener("click", handleSubmit);


Could consider placing all code that runs once on page load in a single function. For example, you could put it inside the page load callback or create a function named init() or setup() and call it once when the page loads.

This makes it easier to locate and manage all the code that runs once when the app starts.

cjyuan · 2026-08-12T12:01:54Z

-const check = document.getElementById("check");
+// Handle form submission
+ function handleSubmit(e) {
+  e.preventDefault();//stop the form from reloading the page


Note: This method does not stop the page from reloading directly. It stops something else that makes the browser from loading a new page. It's an important method to understand.

cjyuan · 2026-08-12T12:04:34Z

-    let book = new Book(title.value, title.value, pages.value, check.checked);
-    library.push(book);
-    render();
+  if (!title || !author || !pages || pages <= 0) {


Although the HTML is prepared to reject non positive whole number, it is a safer practice to also fully check the input in JS code to ensure it is a positive whole number.

Tobias-Amaechina added 10 commits August 5, 2026 22:31

added the closing parenthesis in the for loop

686f27d

used the correct variable name myLibrary inside the submit function

11d4e80

added the autho.value by deleting one of the title.value that was pa…

9acc884

…ssed twice

changed every instance of delBut with delButton

127e4f4

correct the event name by it correct name click

8314db5

changed the wrong logically check from false to yes

8c9db43

added additional validation for book's author

f839c7b

remove the table element from the index.html

ab117d6

add the button ID

55bfed4

appen the corrent variable name delButton

ab20798

Tobias-Amaechina added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 5, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 5, 2026

Tobias-Amaechina added 🏕 Priority Mandatory This work is expected Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 5, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 5, 2026

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

let the row start to add from top

2606f98

Tobias-Amaechina force-pushed the book-library branch from abaaa14 to 2606f98 Compare August 5, 2026 22:30

Tobias-Amaechina added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 🏕 Priority Mandatory This work is expected and removed 🏕 Priority Mandatory This work is expected labels Aug 5, 2026

cjyuan reviewed Aug 6, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 6, 2026

Tobias-Amaechina added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 🏕 Priority Mandatory This work is expected and removed 🏕 Priority Mandatory This work is expected labels Aug 10, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 10, 2026

This comment has been minimized.

Sign in to view

Attached handleSubmit function to window and deleted vscode and sett…

bbef966

…ings.json file

Tobias-Amaechina force-pushed the book-library branch from 7eaaef1 to bbef966 Compare August 10, 2026 13:56

Tobias-Amaechina added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 10, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 10, 2026

Restore .vscode file to avoid validator failure

cde0d51

Tobias-Amaechina added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 🏕 Priority Mandatory This work is expected and removed 🏕 Priority Mandatory This work is expected labels Aug 10, 2026

cjyuan reviewed Aug 11, 2026

View reviewed changes

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 11, 2026

Tobias-Amaechina added 4 commits August 12, 2026 09:04

Add validation attributes to prevent 0 and -ve number as restict it w…

56501c4

…hole number

removed inline onclick and added id attribute submit-btn to the inpu…

58cbad9

…t element

add eventlistener for the onclick

094dfab

Implement the function to stop page from reloading and move event li…

42a3b71

…stener below it

Tobias-Amaechina added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 🏕 Priority Mandatory This work is expected and removed 🏕 Priority Mandatory This work is expected labels Aug 12, 2026

cjyuan reviewed Aug 12, 2026

View reviewed changes

Uh oh!

Uh oh!

Conversation

Tobias-Amaechina commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelist

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Tobias-Amaechina commented Aug 10, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cjyuan Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Tobias-Amaechina commented Aug 5, 2026 •

edited

Loading