Skip to content

London | 26-ITP-May | Yonatan Teklemariam | Sprint 1 | Destructuring - #530

Open
Yonatanteklemariam wants to merge 2 commits into
CodeYourFuture:mainfrom
Yonatanteklemariam:Sprint-1
Open

London | 26-ITP-May | Yonatan Teklemariam | Sprint 1 | Destructuring#530
Yonatanteklemariam wants to merge 2 commits into
CodeYourFuture:mainfrom
Yonatanteklemariam:Sprint-1

Conversation

@Yonatanteklemariam

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

destructured the objects in the functions of the three exercises according to the specified instructions

Questions

@Yonatanteklemariam Yonatanteklemariam added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 8, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 8, 2026
@github-actions

This comment has been minimized.

@Yonatanteklemariam Yonatanteklemariam changed the title London | 26-ITP-May | Yonatan Teklemariam | Sprint 1 | Exercises London | 26-ITP-May | Yonatan Teklemariam | Sprint 1 | Destructuring Aug 8, 2026
@Yonatanteklemariam Yonatanteklemariam added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 8, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great.

You missed Task 2 in exercise-2.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 12, 2026
@Yonatanteklemariam

Copy link
Copy Markdown
Author

Code looks great.

You missed Task 2 in exercise-2.

Thanks for the review. I have completed Task 2 (exercise 2), which involves extracting students of Gryffindor house, if that's what you meant by Task 2. There are only 3 exercises in the destructuring folder and I believe I have completed them all. If there is anything I missed, it would be helpful for me if you could specify exactly which is.
Thanks

@Yonatanteklemariam Yonatanteklemariam added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 13, 2026
@cjyuan

cjyuan commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Exercise 2 has two tasks: https://github.com/Yonatanteklemariam/Module-Data-Flows/tree/Sprint-1/Sprint-1/destructuring/exercise-2#task-2

Task 2 is "display the names of teachers who have pets."

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 13, 2026
@Yonatanteklemariam Yonatanteklemariam added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 13, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants