Skip to content

London | 26-ITP-May | Khaliun Baatarkhuu | Sprint 2 | Book Library #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
khaliun-dev wants to merge 6 commits into
base: main
Choose a base branch
from
Open

London | 26-ITP-May | Khaliun Baatarkhuu | Sprint 2 | Book Library #535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5d4442d
Update input types for title and author fields
khaliun-dev Aug 10, 2026
7736b33
Fix book submission and rendering logic
khaliun-dev Aug 11, 2026
cb6b3a7
Fix book library bugs
khaliun-dev Aug 11, 2026
6b83303
Improve book library code
khaliun-dev Aug 12, 2026
e7089ff
Address reviewer feedback
khaliun-dev Aug 12, 2026
5316766
Delay alert after book deletion
khaliun-dev Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 34 additions & 33 deletions debugging/book-library/index.html
View file
Open in desktop

@cjyuan cjyuan Aug 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://validator.w3.org/, there are errors in your index.html. Could you fix these errors?

Original file line number Diff line number Diff line change
@@ -1,20 +1,22 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<title>My Book Library</title>
<meta charset="utf-8">
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
>

<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>

<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>
<link rel="stylesheet" type="text/css" href="style.css" />
>
<link rel="stylesheet" type="text/css" href="style.css">
</head>

<body>
Expand All @@ -28,46 +30,52 @@ <h1>Library</h1>
</button>

<div id="demo" class="collapse">
<div class="form-group">
<form id="bookForm" class="form-group">
<label for="title">Title:</label>
<input
type="title"
type="text"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
>

<label for="author">Author:</label>
<input
type="author"
type="text"
class="form-control"
id="author"
name="author"
required
/>
>

<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
min="1"
step="1"
required
/>
<label class="form-check-label">
>

<div class="form-check">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
</div>
>
<label class="form-check-label" for="check">
Read
</label>
</div>

<button type="submit" class="btn btn-primary">
Submit
</button>
</form>
</div>

<table class="table" id="display">
Expand All @@ -80,17 +88,10 @@ <h1>Library</h1>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>

<tbody id="bookList"></tbody>
</table>

<script src="script.js"></script>
</body>
</html>
</html>
147 changes: 85 additions & 62 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
let myLibrary = [];
const myLibrary = [];

window.addEventListener("load", function (e) {
populateStorage();
Expand All @@ -7,42 +7,61 @@ window.addEventListener("load", function (e) {

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
const book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true);

const book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
127,
true
);

myLibrary.push(book1);
myLibrary.push(book2);
render();
}
}
const titleInput = document.getElementById("title");
const authorInput = document.getElementById("author");
const pagesInput = document.getElementById("pages");
const readInput = document.getElementById("check");
Comment on lines +23 to +26

@cjyuan cjyuan Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Common practice is to declare all shared variables/constants at the beginning of the files, before function definitions. Doing so makes locating them easier.


const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
}
const bookForm = document.getElementById("bookForm");

@cjyuan cjyuan Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could consider placing all code that runs once on page load in a single function. For example, you could put it inside the page load callback or create a function named init() or setup() and call it once when the page loads.

This makes it easier to locate and manage all the code that runs once when the app starts.


bookForm.addEventListener("submit", function (event) {
event.preventDefault();
addBook();
});

function addBook() {
const title = titleInput.value.trim();
const author = authorInput.value.trim();
const pages = Number(pagesInput.value);

if (
title === "" ||
author === "" ||
!Number.isFinite(pages) ||
pages < 1 ||
!Number.isInteger(pages)
Comment on lines +43 to +45

@cjyuan cjyuan Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you figure out which check is redundant?

@khaliun-dev khaliun-dev Aug 13, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code on line 43, due to another code preventing invalid values anyway.

) {

alert("Please fill all fields correctly!");
return false;
}

const book = new Book(
title,
author,
pages,
readInput.checked
);

myLibrary.push(book);

bookForm.reset();

render();
}
function Book(title, author, pages, check) {
this.title = title;
this.author = author;
Expand All @@ -51,53 +70,57 @@ function Book(title, author, pages, check) {
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
const bookList = document.getElementById("bookList");

bookList.innerHTML = "";

const length = myLibrary.length;

for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
const row = bookList.insertRow();

const titleCell = row.insertCell(0);
const authorCell = row.insertCell(1);
const pagesCell = row.insertCell(2);
const wasReadCell = row.insertCell(3);
const deleteCell = row.insertCell(4);

titleCell.textContent = myLibrary[i].title;
authorCell.textContent = myLibrary[i].author;
pagesCell.textContent = myLibrary[i].pages;

const changeBut = document.createElement("button");

changeBut.className = "btn btn-success";

wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;

const readStatus = myLibrary[i].check ? "Yes" : "No";

changeBut.textContent = readStatus;

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);

const delButton = document.createElement("button");

delButton.className = "btn btn-warning";
delButton.textContent = "Delete";

deleteCell.appendChild(delButton);

delButton.addEventListener("click", function () {
const deletedTitle = myLibrary[i].title;

myLibrary.splice(i, 1);
render();

setTimeout(function () {
alert(`You've deleted title: ${deletedTitle}`);
}, 0);
});
}
}