Skip to content

Glasgow | 26-ITP-May | Niangh Ciang | Sprint 3 | Alarm Clock #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Niangh-Ciang wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Glasgow | 26-ITP-May | Niangh Ciang | Sprint 3 | Alarm Clock #1273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d0554ad
Update the title to 'Alarm clock app'
Niangh-Ciang Jul 19, 2026
83993fd
Implement alarm clock countdown logic
Niangh-Ciang Jul 19, 2026
427106d
Add input validation to prevent empty or invalid alarm values
Niangh-Ciang Jul 27, 2026
fee8dfb
Fix countdown issue by stopping the previous timer before starting a …
Niangh-Ciang Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion Sprint-3/alarmclock/alarmclock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,35 @@
function setAlarm() {}
let countdownInterval = null;

function setAlarm() {

@LonMcGregor LonMcGregor Jul 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you properly handled input validation?

@Niangh-Ciang Niangh-Ciang Jul 27, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve added input validation so the alarm will show a message when no time is set or when the time is zero or negative.

const timeInput = document.getElementById("alarmSet");
let remainingTime = Number(timeInput.value);

if (!timeInput.value || remainingTime <= 0) {
alert("Please set a valid time!");
return;
}

const timeRemainingDisplay = document.getElementById("timeRemaining");

if (countdownInterval !== null) {
clearInterval(countdownInterval);
}

timeRemainingDisplay.innerText = `Time Remaining: ${formatTime(remainingTime)}`;
countdownInterval = setInterval(() => {
remainingTime -= 1;
if (remainingTime === 0) {
playAlarm();
clearInterval(countdownInterval);
}
timeRemainingDisplay.innerText = `Time Remaining: ${formatTime(remainingTime)}`;
}, 1000);
}
function formatTime(seconds) {
const mm = String(Math.floor(seconds / 60)).padStart(2, "0");
const ss = String(seconds % 60).padStart(2, "0");
return `${mm}:${ss}`;
}

// DO NOT EDIT BELOW HERE

Expand Down
4 changes: 2 additions & 2 deletions Sprint-3/alarmclock/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<!DOCTYPE html>
<!doctype html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="style.css" />
<title>Title here</title>
<title>Alarm clock app</title>
</head>
<body>
<div class="centre">
Expand Down