London | 26-ITP-May | Eyob Zeray | Sprint 3 | Implement and rewrite tests coursework - #1547
Open
eyob-tech wants to merge 4 commits into
Open
Conversation
eyob-tech
added
📅 Sprint 3
eyob-tech
changed the title
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jul 27, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Very close to be complete, one test case left.
| }); | ||
|
|
||
| // Case: improper fractions | ||
| test('should return false when the fraction is improper', () => { |
There was a problem hiding this comment.
Do you have a test case here for negative improper fractions?
Author
There was a problem hiding this comment.
Hey Lon, good spot — you were right, I hadn't covered negative improper fractions. Added a test for isProperFraction(-7, 3) (should return false) and checked the implementation handles it fine since it uses Math.abs() in the comparison. Just pushed the fix, ready for another look whenever you get a chance
LonMcGregor
added
Reviewed
eyob-tech
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implemented getAngleType, isProperFraction, and getCardValue in the implement directory, with tests covering boundary and edge cases for each. Rewrote the same test cases using Jest in rewrite-tests-with-jest. All Jest tests pass via npm test.