feat(marketplace): destination tab picker and completion feedback

[LWS49]

Summary

This rounds out the preview/duplicate flow from the parent PR. The duplicate confirmation dialog now lets the user actively pick the destination category/tab via a new DestinationTabPicker, instead of just displaying whichever tab they happened to arrive from. Completion feedback is upgraded to report once the duplication job actually finishes, with a link to where the assessment landed, instead of a fire-and-forget "started" toast. The listing preview page is badged so it's never mistaken for the real assessment it mirrors, and a bare /marketplace/listings now redirects to the marketplace index instead of 404ing.

Design decisions

• DuplicateConfirmation now takes the full destinationTabs list and an initialDestinationTabId, letting the user change the destination tab instead of being locked into the one they arrived from; the initial selection still defaults to the from_tab tab when it names a real tab, falling back to the course's first tab otherwise.
• The completion toast now fires from pollJob's completion callback and links to the duplicated assessment (redirectUrl), since the previous "Duplicating assessment started." toast fired on job submission and gave no way to find the result afterward.
• The selected tab is only re-seeded when the dialog reopens ([open] as the sole effect dependency), not on every parent re-render, so an in-progress tab choice isn't reset out from under the user while the dialog stays open.

Regression prevention

Tests cover: DestinationTabPicker's category grouping (including tabs arriving non-contiguously) and its selection wiring; the tab-selection reset-on-reopen vs. preserve-while-open behaviour; the completion and failure toast copy and the redirect link; the dialog locking/unlocking around an in-flight job so it can't be double-submitted or abandoned mid-job; the destinationTabs now returned from the listing show endpoint; the /marketplace/listings redirect; and the listing preview page's "Preview" badge.

Manual testing covered picking a different destination tab before confirming, the completion toast and its link after a duplication job finishes, a failed duplication leaving the dialog open for retry, and the bare /marketplace/listings redirect.

[Copilot]

Pull request overview

This PR completes the marketplace listing duplicate/preview flow by letting users choose the destination assessment tab at duplication time, and by improving UX feedback (preview badging + completion toast with link) after the duplication job finishes.

Changes:

• Add a DestinationTabPicker and wire DuplicateConfirmation to accept destinationTabs + initialDestinationTabId, preserving user selection while open and re-seeding on reopen.
• Move “duplication completed” feedback to the job poller completion callback, including an optional link to the duplicated assessment’s landing tab.
• Add preview-page “Preview” badging and route /marketplace/listings → marketplace index redirect; extend listing show payload to include destination tabs.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
spec/controllers/course/assessment/marketplace/listings_controller_spec.rb	Adds coverage to ensure listing show returns destinationTabs for the UI picker.
client/locales/en.json	Adds/updates strings for preview badge, tab picker, and completion/failure toasts.
client/locales/ko.json	Adds/updates strings for preview badge, tab picker, and completion/failure toasts.
client/locales/zh.json	Adds/updates strings for preview badge, tab picker, and completion/failure toasts.
client/app/routers/course/marketplace.tsx	Redirects bare listings route back to the marketplace index.
client/app/lib/hooks/toast/toast.tsx	Widens toast message typing to accept ReactNode (to support link-in-toast).
client/app/bundles/course/marketplace/types.ts	Extends listing preview data type to include destinationTabs.
client/app/bundles/course/marketplace/translations.ts	Adds new marketplace i18n keys (picker label, completion/failure copy, view link).
client/app/bundles/course/marketplace/pages/MarketplaceIndex/index.tsx	Passes destinationTabs and initial tab id into the duplicate dialog (no longer pre-resolving a fixed destination).
client/app/bundles/course/marketplace/pages/ListingPreview/index.tsx	Adds a “Preview” chip in the page title and wires duplicate dialog to listing-provided destinationTabs.
client/app/bundles/course/marketplace/pages/ListingPreview/test/index.test.tsx	Updates fixtures for destinationTabs and adds a test asserting the preview badge.
client/app/bundles/course/marketplace/components/DuplicateConfirmation.tsx	Implements tab selection UI + job-completion toast/link; shows duplicating list with badges/tooltips.
client/app/bundles/course/marketplace/components/DestinationTabPicker.tsx	New component: category-grouped tab radio picker.
client/app/bundles/course/marketplace/components/test/DuplicationConfirmation.test.tsx	Adds extensive behavioral tests for selection seeding/preservation, job polling toasts, locking, and redirect link behavior.
client/app/bundles/course/marketplace/components/test/DestinationTabPicker.test.tsx	Tests category grouping, ordering, controlled selection, and onChange wiring.
client/app/bundles/course/duplication/components/TypeBadge/index.tsx	Adds dense option to support compact badges in marketplace UI.
app/views/course/assessment/marketplace/listings/show.json.jbuilder	Emits destinationTabs in listing show JSON.
app/controllers/course/assessment/marketplace/listings_controller.rb	Populates @destination_tabs for show to support the new JSON payload.

Suppressed comments (1)

client/locales/zh.json:6130

• The Simplified Chinese toast strings end with an ASCII period ("."), while nearby strings consistently use the Chinese full stop ("。"). This reads like a localization regression in the UI.

  "course.marketplace.duplicateFailed": {
    "defaultMessage": "{n, plural, one {无法复制评估} other {无法复制评估}}."
  },

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.