chore: drop boto for signurlarity - #8731
Draft
natthan-pigoux wants to merge 2 commits into
Draft
Conversation
natthan-pigoux
marked this pull request as draft
August 4, 2026 15:17
natthan-pigoux
changed the title
natthan-pigoux
commented
Aug 12, 2026
| dest_file = os.path.join(localPath if localPath else os.getcwd(), fileName) | ||
| log.debug(f"Trying to download {src_key} to {dest_file}") | ||
|
|
||
| self.s3_client.download_file(self.bucketName, src_key, dest_file) |
Contributor
Author
There was a problem hiding this comment.
Do we need a download_file method in signurlarity? or we don't use this dirac getFile?
Contributor
There was a problem hiding this comment.
I am afraid that getFile is a required feature of any storage plugin :-D
Contributor
Author
There was a problem hiding this comment.
Yes I just badly write dirac -> direct ... :)
natthan-pigoux
force-pushed
the
drop_boto_for_signurlarity
branch
from
August 12, 2026 13:16
c5d71ac to
47219ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
CHANGE: Drop boto dependency for signurlarity.
ENDRELEASENOTES
Part of #8641