Add urllib3 zstd extra to requirements#186
Open
dukovac wants to merge 1 commit into
Open
Conversation
Signed-off-by: Stefanie Dukovac <sdukovac@coreweave.com>
dukovac
force-pushed
the
fix/zstd-decode-support
branch
from
cb113bd to
5698912
Compare
Author
|
This issue was first discovered here: DMTF/Redfish-Mockup-Creator#86 |
Contributor
|
While we're here.... we should keep the dependencies in setup.py in sync with requirements.txt... https://github.com/DMTF/python-redfish-library/blob/main/setup.py#L31 It looks like requirements.txt is missing some things though... |
Contributor
|
Suggestions: For setup.py, add this requirement under Update CI testing to move away from older versions of Python. In tox.ini, change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requestssend "Accept-Encoding: *", which some services answer withContent-Encoding: zstd. Without a zstd-capableurllib3, the response body is returned raw and fails JSON parsing ("Service responded with invalid JSON").>=2.6.0is the first release where the [zstd] extra installs the stdlib-based decoder (backports.zstdon Python ≤3.13,compression.zstdon 3.14+) instead of the legacy zstandard package, giving reliableContent-Encoding: zstddecompression across Python versions.