Repository navigation
Conversation
Drarig29
marked this pull request as ready for review
April 10, 2026 17:18
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
This PR moves the structured proxy configuration owned by Synthetics out of
@datadog/datadog-ci-baseand into the Synthetics package, since Synthetics is the only command surface that exposes that JSON proxy config. It also keeps the current tunnel behavior working after the refactor.This reduces the base package API surface by removing Synthetics-specific proxy helpers from it, while keeping the separate
metrics.tsproxy-agentcleanup out of scope for this change.How?
Base request helpers now accept an injected
undicidispatcher instead of a Synthetics-specificproxyOptsobject. Synthetics now owns its localProxyConfigurationtype, proxy URL construction, HTTP dispatcher creation, and tunnel proxy-agent creation in a dedicated proxy helper module.The tunnel and API code were rewired to use those local helpers, and the affected unit tests were updated accordingly. I also ran formatting to address the import-order lint failures reported by CI.
Review checklist