Repository navigation
fix(sourcemaps): limit debug ID registration to one stack frame - #2543
Closed
amortemousque wants to merge 0 commit into
Closed
amortemousque wants to merge 0 commit into
amortemousque wants to merge 0 commit into
Conversation
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🔗 Commit SHA: aff78e6 | Docs | View more details | Give us feedback! |
amortemousque
force-pushed
the
codex/debug-id-stack-limit
branch
from
October 7, 2026 08:00
aff78e6 to
a17526b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
Fixes #2537. Limit debug ID registration to the injected function's stack frame to avoid expensive source-position collection for large bundles. Registration remains synchronous and preserves the bundle URL used by the Browser SDK.
How?
Use the exact runtime snippet from #2542 (921e090): temporarily set
Error.stackTraceLimitto 1 while constructing the error, then restore the original value infinallybefore reading.stack. No descriptor checks or additional fallback logic. The outer catch keeps application execution running if capture fails; a failing strict-mode assignment can skip registration.Keep only two focused runtime tests: one-frame bundle registration with restoration before formatting, and restoration when error construction throws.
Validation:
yarn build,yarn lint(0 errors; existing warnings), and all 118 sourcemap tests pass.Review checklist
Related build-plugins PR: DataDog/build-plugins#553