feat(profiling): Complete OTLP profiles implementation with JFR conversion pipeline

.gitignore

@@ -95,3 +95,4 @@ mise*.local.toml
 
 # Exclude kotlin build files
 .kotlin
+.claude/state/

communication/otlp-exporter/build.gradle.kts

@@ -0,0 +1,26 @@
+plugins {
+  `java-library`
+  id("dd-trace-java.module.internal-library")
+}
+
+description = "otlp-exporter"
+
+// Network/IO classes are hard to unit-test without a real OTLP endpoint; they are exercised
+// via integration tests and the profiling-otel smoke tests instead.
+extra["excludedClassesCoverage"] = listOf(
+  "datadog.communication.otlp.OtlpGrpcSender",
+  "datadog.communication.otlp.OtlpHttpSender",
+  "datadog.communication.otlp.OtlpResponse",
+  "datadog.communication.otlp.OtlpSenderSupport"
+)
+
+dependencies {
+  api(project(":dd-trace-api"))
+  api(project(":communication"))
+  implementation(project(":utils:logging-utils"))
+  implementation(libs.slf4j)
+
+  testImplementation(libs.bundles.junit5)
+  testImplementation(libs.bundles.mockito)
+  testImplementation(libs.okhttp3.mockwebserver)
+}

dd-trace-core/src/main/java/datadog/trace/core/otlp/common/OtlpGrpcRequestBody.java → communication/otlp-exporter/src/main/java/datadog/communication/otlp/OtlpGrpcRequestBody.java

@@ -1,4 +1,4 @@
-package datadog.trace.core.otlp.common;
+package datadog.communication.otlp;
 
 import java.io.IOException;
 import javax.annotation.Nonnull;

dd-trace-core/src/main/java/datadog/trace/core/otlp/common/OtlpGrpcSender.java → communication/otlp-exporter/src/main/java/datadog/communication/otlp/OtlpGrpcSender.java

@@ -1,12 +1,11 @@
-package datadog.trace.core.otlp.common;
+package datadog.communication.otlp;
 
 import static datadog.communication.http.OkHttpUtils.buildHttp2Client;
 import static datadog.communication.http.OkHttpUtils.isPlainHttp;
 
 import datadog.communication.http.HttpRetryPolicy;
 import datadog.logging.RatelimitedLogger;
 import datadog.trace.api.config.OtlpConfig.Compression;
-import datadog.trace.common.writer.RemoteApi;
 import java.util.Map;
 import java.util.concurrent.TimeUnit;
 import okhttp3.HttpUrl;
@@ -53,7 +52,7 @@ public OtlpGrpcSender(
   }
 
   @Override
-  public RemoteApi.Response send(OtlpPayload payload) {
+  public OtlpResponse send(OtlpPayload payload) {
     return OtlpSenderSupport.send(client, retryPolicy, makeRequest(payload), RATELIMITED_LOGGER);
   }
 

dd-trace-core/src/main/java/datadog/trace/core/otlp/common/OtlpHttpRequestBody.java → communication/otlp-exporter/src/main/java/datadog/communication/otlp/OtlpHttpRequestBody.java

@@ -1,4 +1,4 @@
-package datadog.trace.core.otlp.common;
+package datadog.communication.otlp;
 
 import java.io.IOException;
 import javax.annotation.Nonnull;

dd-trace-core/src/main/java/datadog/trace/core/otlp/common/OtlpHttpSender.java → communication/otlp-exporter/src/main/java/datadog/communication/otlp/OtlpHttpSender.java

@@ -1,12 +1,11 @@
-package datadog.trace.core.otlp.common;
+package datadog.communication.otlp;
 
 import static datadog.communication.http.OkHttpUtils.buildHttpClient;
 import static datadog.communication.http.OkHttpUtils.isPlainHttp;
 
 import datadog.communication.http.HttpRetryPolicy;
 import datadog.logging.RatelimitedLogger;
 import datadog.trace.api.config.OtlpConfig.Compression;
-import datadog.trace.common.writer.RemoteApi;
 import java.util.Map;
 import java.util.concurrent.TimeUnit;
 import okhttp3.HttpUrl;
@@ -57,7 +56,7 @@ public HttpUrl url() {
   }
 
   @Override
-  public RemoteApi.Response send(OtlpPayload payload) {
+  public OtlpResponse send(OtlpPayload payload) {
     return OtlpSenderSupport.send(client, retryPolicy, makeRequest(payload), RATELIMITED_LOGGER);
   }
 

dd-trace-core/src/main/java/datadog/trace/core/otlp/common/OtlpPayload.java → communication/otlp-exporter/src/main/java/datadog/communication/otlp/OtlpPayload.java

@@ -1,4 +1,4 @@
-package datadog.trace.core.otlp.common;
+package datadog.communication.otlp;
 
 import java.nio.ByteBuffer;
 

communication/otlp-exporter/src/main/java/datadog/communication/otlp/OtlpResponse.java

@@ -0,0 +1,77 @@
+package datadog.communication.otlp;
+
+import java.util.Optional;
+import java.util.OptionalInt;
+
+/**
+ * Encapsulates the result of an OTLP export attempt.
+ *
+ * <p>If communication fails or times out, the response will NOT be successful and will lack a
+ * status code, but will have an exception.
+ *
+ * <p>If communication succeeds, the response will have a status code and will be marked as success
+ * or failure in accordance with the code.
+ *
+ * <p>NOTE: A successful communication may still contain an exception if there was a problem parsing
+ * the response.
+ */
+public final class OtlpResponse {
+  /** Factory method for a successful request with a trivial response body */
+  public static OtlpResponse success(final int status) {
+    return new OtlpResponse(true, status, null, null);
+  }
+
+  /** Factory method for a successful request with a response body */
+  public static OtlpResponse success(final int status, String response) {
+    return new OtlpResponse(true, status, null, response);
+  }
+
+  /** Factory method for a successful request with a malformed response body */
+  public static OtlpResponse success(final int status, final Throwable exception) {
+    return new OtlpResponse(true, status, exception, null);
+  }
+
+  /** Factory method for a request that received an error status in response */
+  public static OtlpResponse failed(final int status) {
+    return new OtlpResponse(false, status, null, null);
+  }
+
+  /** Factory method for a request that received an error status and a response body */
+  public static OtlpResponse failed(final int status, String response) {
+    return new OtlpResponse(false, status, null, response);
+  }
+
+  /** Factory method for a failed communication attempt */
+  public static OtlpResponse failed(final Throwable exception) {
+    return new OtlpResponse(false, null, exception, null);
+  }
+
+  private final boolean success;
+  private final Integer status;
+  private final Throwable exception;
+  private final String response;
+
+  private OtlpResponse(
+      final boolean success, final Integer status, final Throwable exception, String response) {
+    this.success = success;
+    this.status = status;
+    this.exception = exception;
+    this.response = response;
+  }
+
+  public boolean success() {
+    return success;
+  }
+
+  public OptionalInt status() {
+    return status == null ? OptionalInt.empty() : OptionalInt.of(status);
+  }
+
+  public Optional<Throwable> exception() {
+    return Optional.ofNullable(exception);
+  }
+
+  public String response() {
+    return response;
+  }
+}

communication/otlp-exporter/src/main/java/datadog/communication/otlp/OtlpSender.java

@@ -0,0 +1,8 @@
+package datadog.communication.otlp;
+
+/** Sends chunks of OTLP data. */
+public interface OtlpSender {
+  OtlpResponse send(OtlpPayload payload);
+
+  void shutdown();
+}

dd-trace-core/src/main/java/datadog/trace/core/otlp/common/OtlpSenderSupport.java → communication/otlp-exporter/src/main/java/datadog/communication/otlp/OtlpSenderSupport.java

@@ -1,12 +1,11 @@
-package datadog.trace.core.otlp.common;
+package datadog.communication.otlp;
 
 import static datadog.communication.http.OkHttpUtils.sendWithRetries;
-import static datadog.trace.common.writer.RemoteApi.Response.failed;
-import static datadog.trace.common.writer.RemoteApi.Response.success;
+import static datadog.communication.otlp.OtlpResponse.failed;
+import static datadog.communication.otlp.OtlpResponse.success;
 
 import datadog.communication.http.HttpRetryPolicy;
 import datadog.logging.RatelimitedLogger;
-import datadog.trace.common.writer.RemoteApi;
 import java.io.IOException;
 import okhttp3.OkHttpClient;
 
@@ -15,7 +14,7 @@ final class OtlpSenderSupport {
   private OtlpSenderSupport() {}
 
   /** Executes the given request with retries, logging failures via the rate-limited logger. */
-  static RemoteApi.Response send(
+  static OtlpResponse send(
       OkHttpClient client,
       HttpRetryPolicy.Factory retryPolicy,
       okhttp3.Request request,

dd-trace-core/src/test/java/datadog/trace/core/otlp/common/OtlpGrpcRequestBodyTest.java → communication/otlp-exporter/src/test/java/datadog/communication/otlp/OtlpGrpcRequestBodyTest.java

@@ -1,4 +1,4 @@
-package datadog.trace.core.otlp.common;
+package datadog.communication.otlp;
 
 import static org.junit.jupiter.api.Assertions.assertArrayEquals;
 import static org.junit.jupiter.api.Assertions.assertEquals;

dd-trace-core/src/test/java/datadog/trace/core/otlp/common/OtlpHttpRequestBodyTest.java → communication/otlp-exporter/src/test/java/datadog/communication/otlp/OtlpHttpRequestBodyTest.java

@@ -1,4 +1,4 @@
-package datadog.trace.core.otlp.common;
+package datadog.communication.otlp;
 
 import static org.junit.jupiter.api.Assertions.assertArrayEquals;
 import static org.junit.jupiter.api.Assertions.assertEquals;

dd-trace-core/src/test/java/datadog/trace/core/otlp/common/OtlpSenderSupportTest.java → communication/otlp-exporter/src/test/java/datadog/communication/otlp/OtlpSenderSupportTest.java

@@ -1,4 +1,4 @@
-package datadog.trace.core.otlp.common;
+package datadog.communication.otlp;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
@@ -12,7 +12,6 @@
 import datadog.communication.http.HttpRetryPolicy;
 import datadog.communication.http.OkHttpUtils;
 import datadog.logging.RatelimitedLogger;
-import datadog.trace.common.writer.RemoteApi;
 import java.io.IOException;
 import okhttp3.MediaType;
 import okhttp3.OkHttpClient;
@@ -39,8 +38,7 @@ void successfulResponseIsReturnedWithoutLogging() throws IOException {
           .when(() -> OkHttpUtils.sendWithRetries(client, retryPolicy, request))
           .thenReturn(response);
 
-      RemoteApi.Response result =
-          OtlpSenderSupport.send(client, retryPolicy, request, ratelimitedLogger);
+      OtlpResponse result = OtlpSenderSupport.send(client, retryPolicy, request, ratelimitedLogger);
 
       assertTrue(result.success());
       assertEquals(200, result.status().getAsInt());
@@ -56,8 +54,7 @@ void unsuccessfulResponseIsReturnedAndLogged() throws IOException {
           .when(() -> OkHttpUtils.sendWithRetries(client, retryPolicy, request))
           .thenReturn(response);
 
-      RemoteApi.Response result =
-          OtlpSenderSupport.send(client, retryPolicy, request, ratelimitedLogger);
+      OtlpResponse result = OtlpSenderSupport.send(client, retryPolicy, request, ratelimitedLogger);
 
       assertFalse(result.success());
       assertEquals(500, result.status().getAsInt());
@@ -73,8 +70,7 @@ void ioExceptionIsReturnedAsFailureAndLogged() throws IOException {
           .when(() -> OkHttpUtils.sendWithRetries(client, retryPolicy, request))
           .thenThrow(exception);
 
-      RemoteApi.Response result =
-          OtlpSenderSupport.send(client, retryPolicy, request, ratelimitedLogger);
+      OtlpResponse result = OtlpSenderSupport.send(client, retryPolicy, request, ratelimitedLogger);
 
       assertFalse(result.success());
       assertTrue(result.exception().isPresent());

communication/otlp-exporter/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker

@@ -0,0 +1 @@
+mock-maker-inline

dd-java-agent/agent-profiling/build.gradle

@@ -23,6 +23,7 @@ dependencies {
 
   api project(':dd-java-agent:agent-profiling:profiling-ddprof')
   api project(':dd-java-agent:agent-profiling:profiling-uploader')
+  api project(':dd-java-agent:agent-profiling:profiling-otel')
   api project(':dd-java-agent:agent-profiling:profiling-controller')
   implementation project(':dd-java-agent:agent-profiling:profiling-scrubber')
   api project(':dd-java-agent:agent-profiling:profiling-controller-jfr')
@@ -42,9 +43,31 @@ configurations {
   }
 }
 
+// jafar-tools is a fat jar bundling (an incomplete copy of) the jafar-parser classes; the agent
+// bundles jafar-parser (via profiling-otel) instead and only needs the io.jafar.tools classes
+// (used by profiling-scrubber) from the fat jar
+configurations {
+  jafarTools
+}
+dependencies {
+  jafarTools("io.btrace:jafar-tools:${libs.versions.jafar.get()}") {
+    transitive = false
+  }
+}
+def jafarToolsJar = configurations.jafarTools
+
 tasks.named("shadowJar", ShadowJar) {
   dependencies deps.excludeShared
 
+  // drop the jafar-tools fat jar (parser classes come from jafar-parser via profiling-otel) and
+  // re-add only its unique io/jafar/tools classes to keep a single copy of every class
+  dependencies {
+    exclude(dependency('io.btrace:jafar-tools:.*'))
+  }
+  from({ zipTree(jafarToolsJar.singleFile) }) {
+    include 'io/jafar/tools/**'
+  }
+
   // Exclude multi-release versioned classes from jafar-parser.
   // These are duplicates of base classes for newer Java APIs and confuse
   // the GraalVM native-image builder when the profiling jar is embedded in the agent.

dd-java-agent/agent-profiling/profiling-controller-openjdk/src/main/java/com/datadog/profiling/controller/openjdk/OpenJdkRecordingData.java

@@ -45,7 +45,7 @@ public RecordingInputStream getStream() throws IOException {
   }
 
   @Override
-  public void release() {
+  protected void doRelease() {
     recording.close();
   }
 

dd-java-agent/agent-profiling/profiling-controller-oracle/src/main/java/com/datadog/profiling/controller/oracle/OracleJdkRecordingData.java

@@ -51,7 +51,7 @@ public RecordingInputStream getStream() throws IOException {
   }
 
   @Override
-  public void release() {
+  protected void doRelease() {
     // noop
   }