Skip to content

chore(agents): add verbatim dd-apm-sdk-review skill copy - #12459

Open
robertomonteromiguel wants to merge 7 commits into
masterfrom
robertomonteromiguel/dd-apm-sdk-review-core-copy
Open

chore(agents): add verbatim dd-apm-sdk-review skill copy#12459
robertomonteromiguel wants to merge 7 commits into
masterfrom
robertomonteromiguel/dd-apm-sdk-review-core-copy

Conversation

@robertomonteromiguel

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds a verbatim copy of the shared dd-apm-sdk-review skill so local agents can load it from disk.

  • Source of truth: dd-apm-sdk-review-core#1
  • Files: .agents/skills/dd-apm-sdk-review/ plus Claude/Cursor skill links
  • CODEOWNERS: @DataDog/apm-java (including /.cursor/ so the Cursor link is owned)

This is PR 1 of 2. Java-specific overrides and the perf-review replacement land in the follow-up stacked on this branch.

Motivation

Split out of #12364 so Java reviewers are not asked to read the shared skill copy.

Additional Notes

How to review

  • Do not review the markdown under .agents/skills/dd-apm-sdk-review/. That is a mirror of dd-apm-sdk-review-core#1.
  • Review here: CODEOWNERS / .gitignore (Cursor skill-link exception) only.
  • Edits to the skill belong in the core repo, not this one.

Do not merge this PR on its own — land it with the overrides follow-up.

Made with Cursor

Mirror the shared skill plus Claude/Cursor links. Repo-specific
overrides and the perf-review replacement land in the follow-up.
@robertomonteromiguel

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: c84987cb12

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@datadog-datadog-prod-us1

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.02 s 14.06 s [-1.1%; +0.4%] (no difference)
startup:insecure-bank:tracing:Agent 12.94 s 13.04 s [-1.7%; +0.1%] (no difference)
startup:petclinic:appsec:Agent 17.60 s 17.49 s [-0.1%; +1.4%] (no difference)
startup:petclinic:iast:Agent 17.33 s 17.56 s [-2.3%; -0.3%] (maybe better)
startup:petclinic:profiling:Agent 17.53 s 17.50 s [-1.1%; +1.4%] (no difference)
startup:petclinic:sca:Agent 17.50 s 17.44 s [-0.7%; +1.4%] (no difference)
startup:petclinic:tracing:Agent 16.51 s 16.58 s [-1.4%; +0.5%] (no difference)

Commit: 60061d09 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

Bring in the portable gh --repo pin, optional repo-context, and
.claude/.cursor instruction-only shortcut without tracer-specific edits.
@robertomonteromiguel

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 7bbd159a9a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Load the data-not-instructions rule before repo-context.md.
@robertomonteromiguel

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 756b529a56

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Scan PR title, labels, and commit subjects before printing, using
the same SECRET_GREP path as the diffs.
@robertomonteromiguel

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 745e7a37eb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@robertomonteromiguel
robertomonteromiguel marked this pull request as ready for review September 11, 2026 14:44
@robertomonteromiguel
robertomonteromiguel requested review from amarziali and removed request for a team September 11, 2026 14:44
@dd-octo-sts

dd-octo-sts Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The ownership rule covers Cursor content. The ignore rule excludes local Cursor data and allows the shared skill link.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit 745e7a3 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@dougqh

dougqh commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

The "Check pull requests" status check is failing: "Please add at least one type, and one component or instrumentation label to the pull request."

Per this repo's conventions, please add:

  • a type: label
  • a comp:/inst: label
  • tag: ai generated

@robertomonteromiguel robertomonteromiguel added type: feature Enhancements and improvements comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes labels Sep 14, 2026
Verbatim copy: binary secret-scan fail-closed, LC_ALL=C git diff,
and private routing for no-harness security findings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants