chore(agents): add dd-trace-java overrides for dd-apm-sdk-review - #12460
Conversation
Repo-specific reviewer facts, AGENTS.md hook, llm-validation suite, and replace the retired perf-review skill. Stacked on the verbatim skill copy.
The previous commit copied .gitlab-ci.yml from the old combined branch and dropped unrelated master changes.
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
🎯 Code Coverage (details) 🔗 Commit SHA: 705a16a | Docs | View more details | Give us feedback! |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Keep the stacked overrides branch on the latest verbatim skill copy.
Use the current platform SHA for the GitLab include and the job clone.
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f8f15a0d73
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Keep the stacked overrides branch on the latest verbatim skill copy.
Evaluate crash-handler ordering as a security-lens report, not the orchestrator's redacted output. Require firstSpanWritten to reset on the payload-flush hook, not at every map().
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a96d17e1f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Don't flag feature-flagging modules against an aspirational -lib split; point J1 at EscapeShapeBenchmark; make the HashMap fixture lookup-only. Also merge the skill-copy secret-scan sync.
…robertomonteromiguel/dd-apm-sdk-review-java-overrides
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 84bb97ad43
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
LLM ValidationLLM Validation Gate — dd-apm-sdk-review✅ PASS
AnalysisChanged instruction file(s): No safety or blocking-case regressions across 8 case(s). Overall pairwise win-rate 66% [58%–73%], quality +5.2 — see the verdict above for whether that clears the noise band. Results
Cases
Per-dimension scores, token usage, latency, and estimated cost are in the CI job logs. |
Auto-instrumentations still require InstrumenterModule; product transformers do not. The full-review fixture now states the J10/J12 preconditions the performance override already requires.
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8cbdbb070e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
There was a problem hiding this comment.
The gate does not test the review contract without a skill harness. The security case also accepts P1 although the new rule requires P0.
🤖 Datadog Autotest · Commit 8cbdbb0 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
|
The Also no labels yet — per this repo's conventions, please add:
|
robertomonteromiguel
added
comp: tooling
…robertomonteromiguel/dd-apm-sdk-review-java-overrides
…robertomonteromiguel/dd-apm-sdk-review-java-overrides
The full-skill run was losing the gate to an uninstructed baseline. Evaluate firstSpanWritten the same way as the JS correctness cases.
The security override already calls this P0; the eval case should not accept P1.
2 participants
What does this PR do?
Adds the dd-trace-java layer on top of the shared skill copy.
.agents/dd-apm-sdk-review-overrides/— Java reviewer facts (performance, conventions, design, security, maintainability, repo context)AGENTS.md— short hook: local agents run the skill; Codex readsreview-without-harness.md.llm-validation/— cases that exercise those rules, plus the GitLab"llm validation"include/perf-reviewskill (deleted here; its Java-specific rubric lives in the performance override)Stacked on the core-copy PR. Shared skill source: dd-apm-sdk-review-core#1.
Motivation
This is the half of #12364 that Java reviewers should actually read.
Additional Notes
How to review
.agents/dd-apm-sdk-review-overrides/AGENTS.mdReview Guidelines block.llm-validation/if you care about the gate.agents/skills/dd-apm-sdk-review/— that is the parent PR / core repoMerge with the parent skill-copy PR, not as a standalone.
Made with Cursor