Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The new exclusion uses the exact Drools internal class loader name. The changed tests cover direct name matching and generated Drools types.
🤖 Datadog Autotest · Commit 0298835 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
This comment has been minimized.
This comment has been minimized.
0298835 to
15fdd4d
Compare
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
What Does This Do
Adds
DynamicProjectClassLoader$DefaultInternalTypesClassLoaderto the existing Drools classloader exclusions.This prevents classes loaded through the Drools executable-model path from entering the instrumentation-matching pipeline and triggering repeated class-resource scans.
The change includes:
Motivation
Drools 8 and newer use this internal classloader when defining generated types. Because it was not excluded by default, each new classloader could trigger an expensive instrumentation compatibility scan.
Setting the same classloader through
DD_TRACE_CLASSLOADERS_EXCLUDEavoids the overhead. This change makes that behavior the default, consistent with the existing Drools classloader exclusions.Solves #12469
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]