Avoid Maven failed test replay upload race - #12486
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The long flush interval stops a periodic upload during the Maven smoke test. The shutdown flush still uploads the failed-test replay snapshots.
🤖 Datadog Autotest · Commit 2582965 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
CI Visibility Test Environment - sbt-scalatestJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - nebula-release-pluginJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - pass4sJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - reactive-streams-jvmJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - netflix-zuulJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - sonar-kotlinJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - jolokiaJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
CI Visibility Test Environment - heliboardJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - okhttpJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - spring_bootJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - sonar-javaJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
What Does This Do
Configures the Maven Failed Test Replay smoke test to flush debugger snapshots during JVM shutdown.
This matches the existing setup in
JUnitConsoleSmokeTestand prevents the periodic debugger flush from racing with Surefire JVM shutdown.Motivation
The
[1] failed-test-replaycase inMavenSmokeTesthas been flaky across JDKs, architectures, and regular and SSI smoke jobs.Datadog CI Visibility data for the last 30 days showed 226 failures while waiting for two debugger snapshots. Of those failures, 224 received no snapshots and two received only one. The equivalent JUnit Console test already avoids this race by setting
DYNAMIC_INSTRUMENTATION_UPLOAD_FLUSH_INTERVALto defer periodic flushing.Additional Notes
Verified with:
./gradlew :dd-smoke-tests:maven:spotlessJavaCheck :dd-smoke-tests:maven:test --tests 'datadog.smoketest.MavenSmokeTest.testFailedTestReplay*'Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: N/A