Skip to content

Avoid Maven failed test replay upload race - #12486

Open
daniel-mohedano wants to merge 1 commit into
masterfrom
daniel.mohedano/fix-maven-failed-test-replay-flakiness
Open

Avoid Maven failed test replay upload race#12486
daniel-mohedano wants to merge 1 commit into
masterfrom
daniel.mohedano/fix-maven-failed-test-replay-flakiness

Conversation

@daniel-mohedano

@daniel-mohedano daniel-mohedano commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Configures the Maven Failed Test Replay smoke test to flush debugger snapshots during JVM shutdown.

This matches the existing setup in JUnitConsoleSmokeTest and prevents the periodic debugger flush from racing with Surefire JVM shutdown.

Motivation

The [1] failed-test-replay case in MavenSmokeTest has been flaky across JDKs, architectures, and regular and SSI smoke jobs.

Datadog CI Visibility data for the last 30 days showed 226 failures while waiting for two debugger snapshots. Of those failures, 224 received no snapshots and two received only one. The equivalent JUnit Console test already avoids this race by setting DYNAMIC_INSTRUMENTATION_UPLOAD_FLUSH_INTERVAL to defer periodic flushing.

Additional Notes

Verified with:

./gradlew :dd-smoke-tests:maven:spotlessJavaCheck :dd-smoke-tests:maven:test --tests 'datadog.smoketest.MavenSmokeTest.testFailedTestReplay*'

Contributor Checklist

Jira ticket: N/A

@daniel-mohedano
daniel-mohedano requested a review from a team as a code owner September 14, 2026 15:05
@daniel-mohedano daniel-mohedano added type: bug fix Bug fix tag: no release notes Changes to exclude from release notes comp: ci visibility Continuous Integration Visibility labels Sep 14, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-14T15:08:07.297674Z 2582965 PR opened
🔒 Security Review Completed 2026-09-14T15:08:42.726214Z 2582965 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@daniel-mohedano daniel-mohedano added the tag: ai generated Largely based on code generated by an AI or LLM label Sep 14, 2026

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The long flush interval stops a periodic upload during the Maven smoke test. The shutdown flush still uploads the failed-test replay snapshots.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit 2582965 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

CI Visibility Test Environment - sbt-scalatest

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 57.87 55.43 $\color{red}{\blacktriangle}$ +2.44 55.43 $\color{red}{\blacktriangle}$ +2.44 46/190
agentEvpProxy 58.57 n/a n/a n/a n/a -

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

CI Visibility Test Environment - nebula-release-plugin

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 37.13 36.42 $\color{red}{\blacktriangle}$ +0.71 36.42 $\color{red}{\blacktriangle}$ +0.71 28/101
agentless 37.29 35.70 $\color{red}{\blacktriangle}$ +1.59 35.70 $\color{red}{\blacktriangle}$ +1.59 28/101
agentlessCodeCoverage 45.62 44.48 $\color{red}{\blacktriangle}$ +1.14 44.48 $\color{red}{\blacktriangle}$ +1.14 28/101
agentlessLineCoverage 56.70 55.43 $\color{red}{\blacktriangle}$ +1.27 55.43 $\color{red}{\blacktriangle}$ +1.27 29/102

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

CI Visibility Test Environment - pass4s

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 5.52 9.73 $\color{green}{\blacktriangledown}$ -4.21 9.92 $\color{green}{\blacktriangledown}$ -4.40 22/87
agentless 7.02 9.35 $\color{green}{\blacktriangledown}$ -2.33 9.73 $\color{green}{\blacktriangledown}$ -2.71 22/87
agentlessCodeCoverage 17.63 17.03 $\color{red}{\blacktriangle}$ +0.60 15.72 $\color{red}{\blacktriangle}$ +1.91 19/82

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

CI Visibility Test Environment - reactive-streams-jvm

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 17.31 21.65 $\color{green}{\blacktriangledown}$ -4.34 21.65 $\color{green}{\blacktriangledown}$ -4.34 36/114
agentless 14.27 19.20 $\color{green}{\blacktriangledown}$ -4.93 19.20 $\color{green}{\blacktriangledown}$ -4.93 30/105
agentlessCodeCoverage 15.55 19.59 $\color{green}{\blacktriangledown}$ -4.04 19.99 $\color{green}{\blacktriangledown}$ -4.44 30/103
agentlessLineCoverage 22.14 26.98 $\color{green}{\blacktriangledown}$ -4.84 26.98 $\color{green}{\blacktriangledown}$ -4.84 19/60

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

CI Visibility Test Environment - netflix-zuul

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 88.07 87.80 $\color{red}{\blacktriangle}$ +0.27 87.80 $\color{red}{\blacktriangle}$ +0.27 27/99
agentless 78.45 81.05 $\color{green}{\blacktriangledown}$ -2.60 81.05 $\color{green}{\blacktriangledown}$ -2.60 26/98
agentlessCodeCoverage 94.02 95.12 $\color{green}{\blacktriangledown}$ -1.10 95.12 $\color{green}{\blacktriangledown}$ -1.10 26/98
agentlessLineCoverage 110.64 111.62 $\color{green}{\blacktriangledown}$ -0.98 111.62 $\color{green}{\blacktriangledown}$ -0.98 26/101

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

CI Visibility Test Environment - sonar-kotlin

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 12.36 12.62 $\color{green}{\blacktriangledown}$ -0.26 12.87 $\color{green}{\blacktriangledown}$ -0.51 35/103
agentless 10.28 11.42 $\color{green}{\blacktriangledown}$ -1.14 11.88 $\color{green}{\blacktriangledown}$ -1.60 28/96
agentlessCodeCoverage 13.70 14.81 $\color{green}{\blacktriangledown}$ -1.11 15.11 $\color{green}{\blacktriangledown}$ -1.41 28/96
agentlessLineCoverage 15.94 17.73 $\color{green}{\blacktriangledown}$ -1.79 17.73 $\color{green}{\blacktriangledown}$ -1.79 28/97

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

CI Visibility Test Environment - jolokia

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 94.16 93.23 $\color{red}{\blacktriangle}$ +0.93 93.23 $\color{red}{\blacktriangle}$ +0.93 31/110
agentless 91.15 89.58 $\color{red}{\blacktriangle}$ +1.57 89.58 $\color{red}{\blacktriangle}$ +1.57 30/108
agentlessCodeCoverage 99.37 99.00 $\color{red}{\blacktriangle}$ +0.37 99.00 $\color{red}{\blacktriangle}$ +0.37 30/106
agentlessLineCoverage 98.81 99.00 $\color{green}{\blacktriangledown}$ -0.19 99.00 $\color{green}{\blacktriangledown}$ -0.19 32/111

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@dd-octo-sts

dd-octo-sts Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.02 s 13.89 s [+0.3%; +1.6%] (maybe worse)
startup:insecure-bank:tracing:Agent 12.83 s 12.92 s [-1.5%; +0.1%] (no difference)
startup:petclinic:appsec:Agent 17.54 s 17.36 s [+0.2%; +1.8%] (maybe worse)
startup:petclinic:iast:Agent 17.31 s 17.51 s [-1.8%; -0.4%] (maybe better)
startup:petclinic:profiling:Agent 17.08 s 17.22 s [-2.0%; +0.5%] (no difference)
startup:petclinic:sca:Agent 17.55 s 17.43 s [-0.3%; +1.7%] (no difference)
startup:petclinic:tracing:Agent 16.49 s 16.68 s [-2.1%; -0.2%] (maybe better)

Commit: 2582965d · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

CI Visibility Test Environment - heliboard

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 9.59 10.13 $\color{green}{\blacktriangledown}$ -0.54 10.13 $\color{green}{\blacktriangledown}$ -0.54 25/96

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

CI Visibility Test Environment - okhttp

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 17.70 19.99 $\color{green}{\blacktriangledown}$ -2.29 19.99 $\color{green}{\blacktriangledown}$ -2.29 24/95
agentless 17.91 19.20 $\color{green}{\blacktriangledown}$ -1.29 19.20 $\color{green}{\blacktriangledown}$ -1.29 25/94
agentlessCodeCoverage 21.10 22.54 $\color{green}{\blacktriangledown}$ -1.44 22.54 $\color{green}{\blacktriangledown}$ -1.44 24/94
agentlessLineCoverage 37.12 38.67 $\color{green}{\blacktriangledown}$ -1.55 38.67 $\color{green}{\blacktriangledown}$ -1.55 25/96

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

CI Visibility Test Environment - spring_boot

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 15.84 16.04 $\color{green}{\blacktriangledown}$ -0.20 16.36 $\color{green}{\blacktriangledown}$ -0.52 28/97
agentless 9.32 9.73 $\color{green}{\blacktriangledown}$ -0.41 9.92 $\color{green}{\blacktriangledown}$ -0.60 26/95
agentlessCodeCoverage 12.90 13.40 $\color{green}{\blacktriangledown}$ -0.50 13.67 $\color{green}{\blacktriangledown}$ -0.77 26/95
agentlessLineCoverage 21.49 22.54 $\color{green}{\blacktriangledown}$ -1.05 22.09 $\color{green}{\blacktriangledown}$ -0.60 25/93

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

CI Visibility Test Environment - sonar-java

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 45.00 9.54 $\color{red}{\blacktriangle}$ +35.46 10.97 $\color{red}{\blacktriangle}$ +34.03 32/110
agentless 15.30 6.65 $\color{red}{\blacktriangle}$ +8.65 8.98 $\color{red}{\blacktriangle}$ +6.32 32/110
agentlessCodeCoverage 93.61 74.82 $\color{red}{\blacktriangle}$ +18.79 74.82 $\color{red}{\blacktriangle}$ +18.79 31/109
agentlessLineCoverage 128.25 111.62 $\color{red}{\blacktriangle}$ +16.63 111.62 $\color{red}{\blacktriangle}$ +16.63 31/107

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: ci visibility Continuous Integration Visibility tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants