Skip to content

Fix Spring Rabbit listener scope close order - #12698

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
andrea.marziali/rabbit-scope-order
Oct 7, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
andrea.marziali/rabbit-scope-order

Conversation

@amarziali

Copy link
Copy Markdown
Contributor

What Does This Do

The listener entry advice activated theamqp.consumescope before closing its resumed parent scope, causing an out-of-order close and leaving the parent on the stack until listener completion.

Create the consume span while its parent is active, then close the parent scope before activating the consume scope. This preserves span parentage without relying on delayed stack cleanup.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali
amarziali requested a review from a team as a code owner September 30, 2026 10:41
@amarziali
amarziali requested review from jordan-wong and removed request for a team September 30, 2026 10:41
@amarziali amarziali added type: bug fix Bug fix inst: spring Spring instrumentation labels Sep 30, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T10:53:11.421341Z 23f83c8 PR opened
🔒 Security Review ✅ Completed 2026-09-30T10:47:27.173197Z 23f83c8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-prod-us1-6 datadog-prod-us1-6 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The revised ordering preserves consume-span parentage while closing the resumed parent scope before activating the consume scope; no lifecycle defect was identified.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 23f83c8 · @DataDog review to ask questions

@datadog-prod-us1-6

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.97 s 14.04 s [-1.2%; +0.2%] (no difference)
startup:insecure-bank:tracing:Agent 13.02 s 13.02 s [-0.9%; +0.9%] (no difference)
startup:petclinic:appsec:Agent 17.09 s 16.97 s [-0.5%; +1.9%] (no difference)
startup:petclinic:iast:Agent 17.07 s 17.07 s [-0.9%; +0.9%] (no difference)
startup:petclinic:profiling:Agent 16.49 s 16.88 s [-6.7%; +2.1%] (no difference)
startup:petclinic:sca:Agent 16.97 s 16.92 s [-0.7%; +1.3%] (no difference)
startup:petclinic:tracing:Agent 16.27 s 16.26 s [-1.0%; +1.0%] (no difference)

Commit: 23f83c88 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@amarziali
amarziali requested review from ygree and removed request for ygree October 5, 2026 15:31

@jordan-wong jordan-wong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amarziali

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-10-07 16:04:59 UTC ℹ️ Start processing command /merge


2026-10-07 16:05:08 UTC ℹ️ MergeQueue: Pull request is not mergeable yet

It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.

  • Run /code blockers to see what is blocking it.
  • Run /remove to cancel it.

2026-10-07 20:10:09 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@amarziali

Copy link
Copy Markdown
Contributor Author

/code blockers

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-10-07 20:24:32 UTC ℹ️ Start processing command /code blockers


2026-10-07 20:24:33 UTC ℹ️ Devflow:

Checking merge blockers for #12698...


2026-10-07 20:24:38 UTC ℹ️ Devflow: /code blockers

No merge blockers detected.

@amarziali amarziali added the tag: override groovy enforcement Override the "Enforce Groovy Migration" check label Oct 7, 2026
@amarziali

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-10-07 20:25:19 UTC ℹ️ Start processing command /merge


2026-10-07 20:25:23 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-10-07 22:24:51 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit e74c095 into master Oct 7, 2026
614 of 617 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the andrea.marziali/rabbit-scope-order branch October 7, 2026 22:24
@github-actions github-actions Bot added this to the 1.68.0 milestone Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: spring Spring instrumentation tag: override groovy enforcement Override the "Enforce Groovy Migration" check type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants