Replace FieldBackedContextAccessor with KeyWithValue by mcculls · Pull Request #12750 · DataDog/dd-trace-java

mcculls · 2026-10-05T18:55:13Z

What Does This Do

Replaces FieldBackedContextAccessor with KeyWithValue from dd-instrument-java

Motivation

This is step 1 of separating out field-injection from all the other transformations needed for tracing, etc.

Contributor Checklist

Format the title according to the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any other useful labels
Avoid using close, fix, or any linking keywords when referencing an issue
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, migration, or deletion
Update public documentation with any new configuration flags or behaviors
Once approved, use merge queue to merge the PR

Jira ticket: [PROJ-IDENT]

chatgpt-codex-connector · 2026-10-06T09:28:21Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-06T09:35:11.460283Z	`eae4304`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

datadog-prod-us1-4

More details

The new KeyWithValue contract is applied consistently across field injection, context access, matching, and module visibility, with no actionable compatibility regression identified.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit eae4304 · @DataDog review to ask questions}

datadog-prod-us1-4

More details

The new KeyWithValue accessor signatures and weak-map dispatch paths match instrument-java 0.0.6. Validation is limited to source and published dependency bytecode inspection.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit eae4304 · @DataDog review to ask questions}

dd-octo-sts · 2026-10-07T14:07:58Z

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	13.87 s	13.94 s	[-1.1%; +0.0%] (no difference)
startup:insecure-bank:tracing:Agent	12.77 s	12.90 s	[-1.6%; -0.5%] (maybe better)
startup:petclinic:appsec:Agent	17.08 s	16.99 s	[-0.4%; +1.4%] (no difference)
startup:petclinic:iast:Agent	16.87 s	16.91 s	[-1.1%; +0.7%] (no difference)
startup:petclinic:profiling:Agent	16.59 s	16.68 s	[-1.5%; +0.5%] (no difference)
startup:petclinic:sca:Agent	17.04 s	16.98 s	[-0.5%; +1.1%] (no difference)
startup:petclinic:tracing:Agent	16.02 s	15.75 s	[-2.7%; +6.2%] (no difference)

Commit: b7a8fe7f · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

…nt-java This is step 1 of separating out field-injection from all the other transformations needed for tracing, etc.

dd-octo-sts · 2026-10-07T16:11:20Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-10-07T16:11:24Z

View all feedbacks in Devflow UI.

2026-10-07 16:11:23 UTC ℹ️ Start processing command /merge

2026-10-07 16:11:27 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-10-07 16:46:58 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for b1997ff:

Ubuntu_23_10_arm64.SI94: [test-app-java-container]

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

mcculls · 2026-10-07T17:43:40Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-10-07T17:43:45Z

View all feedbacks in Devflow UI.

2026-10-07 17:43:44 UTC ℹ️ Start processing command /merge

2026-10-07 17:43:48 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-10-07 17:59:50 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 6a74c07:

check_build_src

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

mcculls · 2026-10-07T18:49:11Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-10-07T18:49:15Z

View all feedbacks in Devflow UI.

2026-10-07 18:49:15 UTC ℹ️ Start processing command /merge

2026-10-07 18:49:19 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-10-07 19:06:03 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 0ff5f3c:

check_build_src

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

mcculls · 2026-10-07T19:08:41Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-10-07T19:08:46Z

View all feedbacks in Devflow UI.

2026-10-07 19:08:45 UTC ℹ️ Start processing command /merge

2026-10-07 19:08:49 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-10-07 20:23:55 UTC ℹ️ MergeQueue: This merge request was merged

mcculls added comp: core Tracer core type: refactoring labels Oct 5, 2026

mcculls marked this pull request as ready for review October 6, 2026 09:28

mcculls requested review from a team as code owners October 6, 2026 09:28

mcculls requested review from AlexeyKuznetsov-DD and ygree and removed request for a team October 6, 2026 09:28

datadog-prod-us1-4 Bot reviewed Oct 6, 2026

View reviewed changes

Base automatically changed from mcculls/dd-instrument-java-0.0.6 to master October 7, 2026 12:38

datadog-prod-us1-4 Bot reviewed Oct 7, 2026

View reviewed changes

mcculls force-pushed the mcculls/keywithvalue-accessor branch from eae4304 to d59909c Compare October 7, 2026 13:41

This comment has been minimized.

Sign in to view

Replace FieldBackedContextAccessor with KeyWithValue from dd-instrume…

b7a8fe7

…nt-java This is step 1 of separating out field-injection from all the other transformations needed for tracing, etc.

mcculls force-pushed the mcculls/keywithvalue-accessor branch from d59909c to b7a8fe7 Compare October 7, 2026 14:59

mcculls requested a review from amarziali October 7, 2026 15:00

mcculls enabled auto-merge October 7, 2026 15:19

amarziali approved these changes Oct 7, 2026

View reviewed changes

mcculls added this pull request to the merge queue Oct 7, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 7, 2026

gh-worker-dd-mergequeue-cf854d Bot merged commit 6a0601a into master Oct 7, 2026
627 of 628 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the mcculls/keywithvalue-accessor branch October 7, 2026 20:23

github-actions Bot added this to the 1.68.0 milestone Oct 7, 2026

Conversation

mcculls commented Oct 5, 2026

What Does This Do

Motivation

Contributor Checklist

Uh oh!

chatgpt-codex-connector Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

datadog-prod-us1-4 Bot left a comment

Choose a reason for hiding this comment

Uh oh!

datadog-prod-us1-4 Bot left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

dd-octo-sts Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟢 Java Benchmark SLOs — All performance SLOs passed

Uh oh!

dd-octo-sts Bot commented Oct 7, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

Uh oh!

mcculls commented Oct 7, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

mcculls commented Oct 7, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

mcculls commented Oct 7, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chatgpt-codex-connector Bot commented Oct 6, 2026 •

edited

Loading

dd-octo-sts Bot commented Oct 7, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Oct 7, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Oct 7, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Oct 7, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Oct 7, 2026 •

edited

Loading