Skip to content

Fix report collection for build tooling projects - #12815

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
alexeyk/collect-reports-roots
Oct 9, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
alexeyk/collect-reports-roots

Conversation

@AlexeyKuznetsov-DD

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

What Does This Do

Collect reports from buildSrc and build-logic as well as workspace, using the actual project directory for copy, move, and delete operations. Enable nullglob so unmatched report roots are skipped.

Motivation

Build tooling reports outside workspace were omitted. Match the project roots used by the JUnit result collector while preserving the existing report layout for workspace projects.

Additional Notes

Validation: Bash syntax check; fixture checks covering copy, move, and delete across all three roots (9 combinations), plus an empty-root case. The extracted script is byte-for-byte identical to the source branch version.

With absent crash files, move mode prints harmless mv usage messages because unmatched globs disappear; commands retain the existing || true handling.

CI artifact before this fix:
image

CI artifact after this fix:
image

Contributor Checklist

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added type: bug fix Bug fix comp: testing Testing tag: no release notes Changes to exclude from release notes tag: ai generated Largely based on code generated by an AI or LLM labels Oct 9, 2026
@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.35% (-0.02%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b429f75 | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.91 s 13.93 s [-0.8%; +0.6%] (no difference)
startup:insecure-bank:tracing:Agent 12.93 s 12.90 s [-0.3%; +0.8%] (no difference)
startup:petclinic:appsec:Agent 17.10 s 17.02 s [-0.4%; +1.3%] (no difference)
startup:petclinic:iast:Agent 16.88 s 16.97 s [-1.3%; +0.2%] (no difference)
startup:petclinic:profiling:Agent 16.48 s 16.81 s [-3.0%; -1.0%] (significantly better)
startup:petclinic:sca:Agent 17.03 s 16.90 s [-0.2%; +1.6%] (no difference)
startup:petclinic:tracing:Agent 16.02 s 16.11 s [-1.6%; +0.4%] (no difference)

Commit: b429f750 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD marked this pull request as ready for review October 9, 2026 14:53
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested review from a team as code owners October 9, 2026 14:53
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested review from bric3 and randomanderson and removed request for a team October 9, 2026 14:53
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T14:55:32.717105Z b429f75 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-09T14:57:21.700377Z b429f75 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-prod-us1-3 datadog-prod-us1-3 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The report-root patterns match the JUnit collector, and workspace projects retain their existing archive destinations while build-tooling reports use their actual project paths.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit b429f75

@bric3 bric3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor Author

/merge -f --reason "No need to run MQ, validated in PR"

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-10-09 16:16:41 UTC ℹ️ Start processing command /merge -f --reason "No need to run MQ, validated in PR"


2026-10-09 16:16:45 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 0s (p90).


2026-10-09 16:16:56 UTC ℹ️ MergeQueue: This merge request was merged

Warning

This change was merged without running any pre merge CI checks

Reason: No need to run MQ, validated in PR

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit f45dec8 into master Oct 9, 2026
622 of 628 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the alexeyk/collect-reports-roots branch October 9, 2026 16:16
@github-actions github-actions Bot added this to the 1.68.0 milestone Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: testing Testing tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants