Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (362.763 µs) : 309, 417
. : milestone, 363,
basic (327.406 µs) : 321, 334
. : milestone, 327,
loop (8.096 ms) : 8034, 8159
. : milestone, 8096,
section candidate
noprobe (342.598 µs) : 316, 369
. : milestone, 343,
basic (326.946 µs) : 322, 332
. : milestone, 327,
loop (8.097 ms) : 8034, 8160
. : milestone, 8097,
|
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This was referenced Nov 1, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Reformats 342 Java files with Google Java Format 2.0.0 and its default cleanup pass. No non-Java files are changed.
Representative Formatting Changes
These examples use the exact source sites and inputs from #12444 and #12445, at commit
36ca5fbc827f21df1ebd9574ed4ba36c917958a3. The PR stack itself starts from current master,c30d76e0715baa06b6104606f8285153c66a6b04.The output below comes from Google Java Format 2.0.0 with the default Google style and cleanups enabled, and long-string reflow disabled, matching the Spotless configuration.
Lambda Pipelines
The sole lambda argument now starts beside
forEach, reducing the indentation inside its body.PluginApplication.javaExtension.EXTENSIONS.stream() .filter(ext -> ext.appliesTo(spec)) - .forEach( - ext -> { + .forEach(ext -> {Fluent Calls
This fluent call keeps its existing layout.
AdviceGeneratorImpl.javaNested Callbacks
Both sole lambda arguments move beside their calls. The scheduler call keeps a continuation line.
CoreTracer.javaNested Lambda Pipelines
The
mapandflatMaplambdas move beside their calls, reducing the indentation of the nested pipeline.AssertBuilder.javareturn type.getAnnotationByName("AutoService") - .<Set<Class<?>>>map( - annotation -> - annotation.asNormalAnnotationExpr().getPairs().stream() - .filter(pair -> pair.getNameAsString().equals("value")) - .flatMap( - pair -> - pair.getValue().asArrayInitializerExpr().getValues().stream() + .<Set<Class<?>>>map(annotation -> + annotation.asNormalAnnotationExpr().getPairs().stream() + .filter(pair -> pair.getNameAsString().equals("value")) + .flatMap(pair -> + pair.getValue().asArrayInitializerExpr().getValues().stream()Parameter Wrapping
The same method signature keeps its existing layout.
PluginApplication.javaControl-flow Braces
The single-statement
ifkeeps its existing layout.CoreTracer.javaJavadoc Formatting
This one-line Javadoc stays on one line.
CoreTracer.java/** Tracer start time in nanoseconds measured up to a millisecond accuracy */Inline Comment Placement
The argument comment stays beside
null.CoreTracer.javaImport Separation
The blank line between static and regular imports is preserved.
PluginApplication.javaSwitch Blocks Stay Unchanged
The same switch case keeps its existing layout.
JsonToExpressionConverter.javaDefault Cleanups
Google Java Format 2.0.0 also removes this redundant semicolon in the original
CoreTracerinput. The cleanup pass is enabled by default. It also supports removing empty annotation parentheses and parentheses around a single untyped lambda parameter.CoreTracer.javafinal Pair<String, CharSequence> serviceNameAndSource = traceConfig.getPreferredServiceNameAndSource(); - ; if (serviceNameAndSource != null && serviceNameAndSource.hasLeft()) {Motivation
Keep the mechanical output separate from the formatter configuration in #13144. The stack starts from current master, while the showcase reuses the original inputs from the earlier formatter experiments for direct comparison.
Additional Notes
This draft is stacked on #13144.
A Java 25 parsed-source audit of all 342 changed files found no unexpected differences in source structure, identifiers, literal values, TableTest rows, comment content and placement, or Spotless-fenced regions. The audit allows the documented cleanup transformations. It checked 32,284 literal values, 130 TableTest annotations, 4,124 comments, and 14 fenced regions.
TagInterceptorTestwas run with a temporary init script that removes the unused container-image JVM argument provider from:dd-trace-core:test, with task reuse and build-cache reuse disabled. The normal task attempted to resolve a private test-agent image before starting this container-free test and could not reach the registry. The init script is outside the repository and is not part of this PR.Focused core-test workaround (165 tests passed)
Save this as a temporary
focused-core-test.init.gradle.kts:The full repository test suite and performance benchmarks were not run.
Related experiments: #12421 / #12422 and #12444 / #12445.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue