chore(agents): add starter dd-trace-php overrides for dd-apm-sdk-review - #4191
Conversation
One PSR-2 convention rule, a short AGENTS.md hook, and one llm-validation case. Co-authored-by: Cursor <cursoragent@cursor.com>
|
GitHub Codex follows markdown links in AGENTS.md. Link the skill folder (same hook as js/go/rb) and review-without-harness.md so the review spec lands in the GitHub review context. Co-authored-by: Cursor <cursoragent@cursor.com>
Document how to add a review-skill case and how to run the suite locally, same shape as dd-trace-go / dd-trace-rb.
Watch the full skill tree like go/rb, ignore local eval artifacts, and give PHP an explicit CODEOWNERS + CONTRIBUTING pointer for the gate.
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb69c9011c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| ## PHP userland follows PSR-2 | ||
|
|
||
| PHP under this repo must follow [PSR-2](https://www.php-fig.org/psr/psr-2/). Style is checked with `composer lint` and auto-fixed with `composer fix-lint`. A new or edited `.php` file that uses Allman braces, tabs for indent, or otherwise fails that check is a finding. Do not invent a different house style. |
There was a problem hiding this comment.
When reviewing a class or method that correctly puts its opening brace on the next line, this instruction tells the reviewer to report the compliant Allman-style placement as a defect, even though the cited PSR-2 source of truth requires that placement and the repository uses it throughout. This will produce false review findings; remove “Allman braces” from the prohibited examples and describe the fixture’s actual excessive brace indentation instead.
AGENTS.md reference: AGENTS.md:L15-L17
Useful? React with 👍 / 👎.
1 participant
What does this PR do?
Adds the dd-trace-php layer on top of the shared skill copy.
.agents/dd-apm-sdk-review-overrides/— one starter PHP reviewer fact: userland follows PSR-2 /composer lint(fix withcomposer fix-lint), as written inCONTRIBUTING.md§ "PHP linting"AGENTS.md— short hook (this repo had none): local agents run the skill; Codex readsreview-without-harness.md.llm-validation/— first suite in this repo, one case (php-conventions-psr2), plus the GitLab"llm validation"includeStacked on the core-copy PR (#4190). Shared skill source: dd-apm-sdk-review-core#1.
Motivation
This is the half that PHP reviewers should actually read. The repo had no agent hook or eval gate yet; this lands the minimum so the skill is usable.
Additional Notes
How to review
.agents/dd-apm-sdk-review-overrides/AGENTS.mdReview Guidelines block.llm-validation/if you care about the gate.agents/skills/dd-apm-sdk-review/— that is the parent PR / core repoMerge with the parent skill-copy PR, not as a standalone.
Reviewer checklist
Made with Cursor