Skip to content

ci: trigger Changelog check on PR title/body edits - #20090

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
brian.marks/changelog-edited-trigger-2
Sep 8, 2026
Merged

ci: trigger Changelog check on PR title/body edits#20090
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
brian.marks/changelog-edited-trigger-2

Conversation

@bm1549

@bm1549 bm1549 commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

Description

The Ensure release note added step in .github/workflows/changelog.yml (scripts/check-releasenotes) gates the changelog/no-changelog label exemption on whether the PR title starts with fix or feat. The pull_request trigger didn't include the edited activity type, so renaming a PR title (e.g. from fix(...) to chore(...)) doesn't re-run the check with the new title. Re-running the job manually doesn't help either, since GitHub Actions reruns replay the original cached webhook payload rather than fetching the PR's current state — so a stale title check keeps failing indefinitely until a fresh pull_request event (like a push) fires.

Adding edited to the trigger types makes the workflow fire a fresh event (with the current title) whenever the title or body changes, so the check self-heals after a title rename instead of requiring an unrelated commit to unstick it.

Testing

No new tests — this is a single-line change to a workflow trigger. Verified the updated YAML parses correctly.

Risks

Low. The edited event also fires on PR body-only edits, so the job (checkout + a bash script + reno lint) will run slightly more often. The job doesn't use secrets or run on pull_request_target, so there's no new security surface.

Additional Notes

Prompted by PR #20047, where a rename from fix(tests): ... to chore(tests): ... left the Changelog check stuck on a stale fix(tests): ... failure across multiple reruns.

@bm1549
ci: trigger Changelog check on PR title/body edits
45e0cd3 
The check-releasenotes script gates the changelog/no-changelog label
exemption on whether the PR title starts with fix/feat. Re-running the
job replays the original cached webhook payload, so a title rename
after the fact doesn't get picked up until a fresh pull_request event
fires. Adding 'edited' to the trigger types makes the check re-run
automatically when the title changes.
@bm1549 bm1549 added AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos changelog/no-changelog A changelog entry is not required for this PR. labels Sep 5, 2026
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Codeowners resolved as

Resolved from the full PR diff against main using the target branch CODEOWNERS file.
CODEOWNERS team requests not listed below are not required by the current file set.

No remaining files require a CODEOWNERS review.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 2 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector
ddtrace.appsec._asm_request_context -> ddtrace.appsec._iast._iast_request_context_base -> ddtrace.appsec._iast._iast_env -> ddtrace.appsec._iast.reporter -> ddtrace.appsec._exploit_prevention.stack_traces -> ddtrace.appsec._asm_request_context

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 230 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 230 highest severity) 
ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=134)
ddtrace.llmobs._integrations.anthropic -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=132)
ddtrace.llmobs._integrations.langchain -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=132)
ddtrace.llmobs._evaluators.runner -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=132)
ddtrace.llmobs._integrations.vertexai -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=132)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Sep 5, 2026 •
edited by datadog-datadog-prod-us1-2 Bot
Loading

Copy link
Copy Markdown
Contributor

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: db98323 | Docs | View more details | Give us feedback!

@bm1549
bm1549 marked this pull request as ready for review September 5, 2026 17:25
@bm1549
bm1549 requested review from a team as code owners September 5, 2026 17:25
@bm1549
bm1549 requested review from Yun-Kim and juanjux September 5, 2026 17:25
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-05T17:26:35.693087Z 45e0cd3 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@bm1549

bm1549 commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 8, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-08 15:59:21 UTC ℹ️ Start processing command /merge

2026-09-08 15:59:30 UTC ℹ️ MergeQueue: Pull request is not mergeable yet

It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.

  • Run /code blockers to see what is blocking it.
  • Run /remove to cancel it.

2026-09-08 16:13:35 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 57m (p90).

2026-09-08 17:48:25 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit e90472b:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@bm1549

bm1549 commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator Author

/merge -f --reason "Merge queue is extremely flaky. This is a very simple change to a workflow that makes it easier to merge in other code"

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 8, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-08 20:47:01 UTC ℹ️ Start processing command /merge -f --reason "Merge queue is extremely flaky. This is a very simple change to a workflow that makes it easier to merge in other code"

2026-09-08 20:47:06 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 0s (p90).

2026-09-08 20:47:14 UTC ℹ️ MergeQueue: This merge request was merged

Warning

This change was merged without running any pre merge CI checks

Reason: Merge queue is extremely flaky. This is a very simple change to a workflow that makes it easier to merge in other code

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit c86e2c5 into main Sep 8, 2026
419 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the brian.marks/changelog-edited-trigger-2 branch September 8, 2026 20:47
@bm1549 bm1549 mentioned this pull request Sep 8, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettlangdon brettlangdon brettlangdon approved these changes
@mabdinur mabdinur mabdinur approved these changes
@Yun-Kim Yun-Kim Awaiting requested review from Yun-Kim Yun-Kim is a code owner automatically assigned from DataDog/python-guild
@juanjux juanjux Awaiting requested review from juanjux juanjux is a code owner automatically assigned from DataDog/apm-core-python

Assignees

No one assigned

Labels

AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bm1549 @brettlangdon @mabdinur