Skip to content

fix(rq): support worker hierarchy in rq 2.7+ - #20104

Open
Hanane-Laassilia wants to merge 8 commits into
mainfrom
update-rq
Open

fix(rq): support worker hierarchy in rq 2.7+#20104
Hanane-Laassilia wants to merge 8 commits into
mainfrom
update-rq

Conversation

@Hanane-Laassilia

Copy link
Copy Markdown

Description

Supersedes #19804, where the automated RQ update failed because RQ 2.7 moved perform_job to BaseWorker. Wraps the method owner so all worker types, including SimpleWorker, are traced. Also updates test locks through RQ 2.12 and adds Python 3.14 coverage.

Testing

  • RQ 2.7 / Python 3.9: 21 passed
  • RQ 2.12 / Python 3.14: 21 passed
  • Registry tests: 3 passed
  • Riot lint passed

Additional Notes

Replaces the failed automated update in #19804.

@datadog-official

datadog-official Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0524cf1 | Docs | View more details | Give us feedback!

@pr-commenter

pr-commenter Bot commented Sep 7, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-09-07 12:34:29

Comparing candidate commit 0524cf1 in PR branch update-rq with baseline commit a03391b in branch main.

📊 Benchmarking dashboard

Found 0 performance improvements and 6 performance regressions! Performance is the same for 580 metrics, 10 unstable metrics, 2 known flaky benchmarks, 16 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:httppropagationinject-ids_only

  • 🟥 execution_time [+2.221µs; +2.412µs] or [+13.055%; +14.183%]

scenario:iastaspects-join_aspect

  • 🟥 execution_time [+49.188µs; +54.554µs] or [+23.423%; +25.978%]

scenario:iastaspects-stringio_aspect

  • 🟥 execution_time [+621.666µs; +666.540µs] or [+19.070%; +20.447%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+108.091µs; +116.142µs] or [+26.014%; +27.952%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+571.229ns; +621.069ns] or [+21.061%; +22.898%]

scenario:tracer-small

  • 🟥 execution_time [+38.450µs; +41.412µs] or [+11.430%; +12.311%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:coreapiscenario-context_with_data_listeners

  • unstable execution_time [-753.471ns; +739.479ns] or [-6.775%; +6.649%]

scenario:coreapiscenario-core_dispatch_1_listener

  • unstable execution_time [-30.865ns; +34.560ns] or [-5.063%; +5.669%]

scenario:coreapiscenario-core_dispatch_50_listeners

  • unstable execution_time [-1665.812ns; +1619.939ns] or [-9.831%; +9.560%]

scenario:coreapiscenario-core_dispatch_exception_listeners

  • unstable execution_time [-1220.133ns; +1256.262ns] or [-9.422%; +9.701%]

scenario:coreapiscenario-core_dispatch_listeners

  • unstable execution_time [-329.521ns; +319.057ns] or [-9.040%; +8.753%]

scenario:coreapiscenario-core_dispatch_no_args_listeners

  • unstable execution_time [-257.548ns; +249.735ns] or [-8.860%; +8.591%]

scenario:coreapiscenario-core_dispatch_with_results_1_listener

  • unstable execution_time [-79.638ns; +71.576ns] or [-6.988%; +6.280%]

scenario:coreapiscenario-core_dispatch_with_results_50_listeners

  • unstable execution_time [-4051.946ns; +3949.819ns] or [-9.872%; +9.623%]

scenario:coreapiscenario-core_dispatch_with_results_listeners

  • unstable execution_time [-851.407ns; +752.424ns] or [-10.396%; +9.188%]

scenario:packagesupdateimporteddependencies-import_many_stdlib_cached

  • unstable execution_time [-56.435µs; +54.224µs] or [-9.746%; +9.364%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:iastaspects-casefold_noaspect

  • 🟥 execution_time [+28.347µs; +34.254µs] or [+11.415%; +13.793%]

scenario:span-start

  • 🟥 execution_time [+1.941ms; +2.151ms] or [+13.950%; +15.461%]

Known flaky benchmarks without significant changes:

  • scenario:errortrackingflasksqli-baseline
  • scenario:flasksimple-iast-get
  • scenario:iastaspects-casefold_aspect
  • scenario:iastaspects-index_aspect
  • scenario:iastaspects-ljust_noaspect
  • scenario:iastaspects-lower_aspect
  • scenario:iastaspects-replace_aspect
  • scenario:iastaspects-swapcase_aspect
  • scenario:iastaspects-title_noaspect
  • scenario:iastaspects-translate_aspect
  • scenario:iastaspects-translate_noaspect
  • scenario:iastaspects-upper_noaspect
  • scenario:packagespackageforrootmodulemapping-cache_off
  • scenario:packagespackageforrootmodulemapping-cache_on
  • scenario:sethttpmeta-all-enabled
  • scenario:telemetryaddmetric-record-100-metrics

@Hanane-Laassilia
Hanane-Laassilia marked this pull request as ready for review September 7, 2026 14:19
@Hanane-Laassilia
Hanane-Laassilia requested review from a team as code owners September 7, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant