Skip to content

fix(agentless): fix agentless crashtracking intake endpoints - #20115

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
bob/fix-agentless-crashtracking
Sep 8, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
bob/fix-agentless-crashtracking

Conversation

@bwoebi

@bwoebi bwoebi commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Turns out the way it was done, the crash reports went through, but the signals to error reporting did not.

libdatadog has the right behaviour, we simply must not compute our own.

This will be covered by a system-test in future.

Turns out the way it was done, the crash reports went through, but the signals to error reporting did not.

libdatadog has the right behaviour, we simply must not compute our own.

This will be covered by a system-test in future.
@bwoebi
bwoebi requested review from a team as code owners September 7, 2026 23:08
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-07T23:12:55.646149Z 4363326 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 3 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.llmobs -> ddtrace.llmobs._evaluators -> ddtrace.llmobs._evaluators.format -> ddtrace.llmobs._experiment -> ddtrace.llmobs
ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector
ddtrace.appsec._asm_request_context -> ddtrace.appsec._iast._iast_request_context_base -> ddtrace.appsec._iast._iast_env -> ddtrace.appsec._iast.reporter -> ddtrace.appsec._exploit_prevention.stack_traces -> ddtrace.appsec._asm_request_context

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2a98420 | Docs | View more details | Give us feedback!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4363326c2a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ddtrace/internal/core/crashtracking.py
@pr-commenter

pr-commenter Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-09-08 00:36:02

Comparing candidate commit 2a98420 in PR branch bob/fix-agentless-crashtracking with baseline commit 93fed02 in branch main.

📊 Benchmarking dashboard

Found 0 performance improvements and 1 performance regressions! Performance is the same for 567 metrics, 10 unstable metrics, 7 known flaky benchmarks, 17 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:otelspan-start

  • 🟥 execution_time [+2.377ms; +3.410ms] or [+7.644%; +10.965%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:coreapiscenario-context_with_data_listeners

  • unstable execution_time [-726.004ns; +738.100ns] or [-6.581%; +6.691%]

scenario:coreapiscenario-core_dispatch_1_listener

  • unstable execution_time [-32.269ns; +33.640ns] or [-5.262%; +5.485%]

scenario:coreapiscenario-core_dispatch_50_listeners

  • unstable execution_time [-1639.899ns; +1654.120ns] or [-9.608%; +9.691%]

scenario:coreapiscenario-core_dispatch_exception_listeners

  • unstable execution_time [-1361.711ns; +1089.733ns] or [-10.381%; +8.308%]

scenario:coreapiscenario-core_dispatch_listeners

  • unstable execution_time [-327.248ns; +322.472ns] or [-8.906%; +8.776%]

scenario:coreapiscenario-core_dispatch_no_args_listeners

  • unstable execution_time [-243.821ns; +260.777ns] or [-8.339%; +8.919%]

scenario:coreapiscenario-core_dispatch_with_results_1_listener

  • unstable execution_time [-64.616ns; +84.539ns] or [-5.655%; +7.398%]

scenario:coreapiscenario-core_dispatch_with_results_50_listeners

  • unstable execution_time [-4058.478ns; +3940.915ns] or [-9.839%; +9.554%]

scenario:coreapiscenario-core_dispatch_with_results_listeners

  • unstable execution_time [-755.675ns; +781.191ns] or [-9.353%; +9.669%]

scenario:packagesupdateimporteddependencies-import_many_stdlib_cached

  • unstable execution_time [-56609.551ns; +54920.073ns] or [-9.694%; +9.404%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:httppropagationinject-ids_only

  • 🟥 execution_time [+2.172µs; +2.343µs] or [+13.011%; +14.039%]

scenario:iastaspects-upper_noaspect

  • 🟥 execution_time [+12.729µs; +16.178µs] or [+7.547%; +9.591%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+131.313µs; +135.440µs] or [+33.748%; +34.809%]

scenario:iastaspectssplit-rsplit_aspect

  • 🟥 execution_time [+16.345µs; +20.999µs] or [+11.540%; +14.825%]

scenario:span-start

  • 🟥 execution_time [+1.578ms; +1.758ms] or [+11.158%; +12.430%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+441.920ns; +489.431ns] or [+15.980%; +17.699%]

scenario:tracer-small

  • 🟥 execution_time [+38.836µs; +41.065µs] or [+11.907%; +12.591%]

Known flaky benchmarks without significant changes:

  • scenario:errortrackingflasksqli-baseline
  • scenario:flasksimple-iast-get
  • scenario:iastaspects-casefold_aspect
  • scenario:iastaspects-casefold_noaspect
  • scenario:iastaspects-index_aspect
  • scenario:iastaspects-ljust_noaspect
  • scenario:iastaspects-lower_aspect
  • scenario:iastaspects-replace_aspect
  • scenario:iastaspects-rstrip_aspect
  • scenario:iastaspects-swapcase_aspect
  • scenario:iastaspects-title_noaspect
  • scenario:iastaspects-translate_aspect
  • scenario:iastaspects-translate_noaspect
  • scenario:packagespackageforrootmodulemapping-cache_off
  • scenario:packagespackageforrootmodulemapping-cache_on
  • scenario:sethttpmeta-all-enabled
  • scenario:telemetryaddmetric-record-100-metrics

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Codeowners resolved as

Resolved from the full PR diff against main using the target branch CODEOWNERS file.
CODEOWNERS team requests not listed below are not required by the current file set.

No remaining files require a CODEOWNERS review.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 230 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 230 highest severity)
ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=134)
ddtrace.internal.ci_visibility.filters -×-> ddtrace.trace  (product:ci_visibility -> product:tracing, score=132)
ddtrace.internal.opentelemetry.trace -×-> ddtrace.trace  (product:opentelemetry -> product:tracing, score=132)
ddtrace.llmobs._integrations.anthropic -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=132)
ddtrace.llmobs._integrations.langchain -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=132)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

@bwoebi
bwoebi requested a review from a team as a code owner September 8, 2026 00:05
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit fa99fc3 into main Sep 8, 2026
1394 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the bob/fix-agentless-crashtracking branch September 8, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants