Skip to content

feat: quantize HTTP client resource names - #6298

Draft
marcotc wants to merge 1 commit into
masterfrom
marcotc/DD_TRACE_HTTP_CLIENT_RESOURCE_NAME_QUANTIZE
Draft

marcotc wants to merge 1 commit into
masterfrom
marcotc/DD_TRACE_HTTP_CLIENT_RESOURCE_NAME_QUANTIZE

Conversation

@marcotc

@marcotc marcotc commented Sep 10, 2026

Copy link
Copy Markdown
Member

No description provided.

@marcotc marcotc added the AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos label Sep 10, 2026
@dd-octo-sts dd-octo-sts Bot added core Involves Datadog core libraries integrations Involves tracing integrations tracing labels Sep 10, 2026
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Tests

✅ All CI checks and tests passed.

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 97.08%
• Overall Coverage: 90.38% (+0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 30e8db2 | Docs | View more details | Give us feedback!

@pr-commenter

pr-commenter Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-09-10 21:28:48

Comparing candidate commit 30e8db2 in PR branch marcotc/DD_TRACE_HTTP_CLIENT_RESOURCE_NAME_QUANTIZE with baseline commit b1b88c9 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 1 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:tracing - Tracing.continue_trace!

  • unstable throughput [-1899.864op/s; +1972.025op/s] or [-4.920%; +5.106%]

@marcotc
marcotc force-pushed the marcotc/DD_TRACE_HTTP_CLIENT_RESOURCE_NAME_QUANTIZE branch from 83a841c to 30e8db2 Compare September 10, 2026 21:01

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos core Involves Datadog core libraries integrations Involves tracing integrations tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant