chore(agents): add dd-trace-rb overrides for dd-apm-sdk-review - #6307
robertomonteromiguel wants to merge 12 commits into
Conversation
Repo-specific reviewer facts, AGENTS.md hook, and llm-validation suite. Stacked on the verbatim skill copy.
|
👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description. If changes need to be present in CHANGELOG.md you can state it this way **Change log entry**
Yes. A brief summary to be placed into the CHANGELOG.md(possible answers Yes/Yep/Yeah) Or you can opt out like that **Change log entry**
None.(possible answers No/Nope/None) Visited at: 2026-09-11 09:59:02 UTC |
|
@codex review |
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 8eb9c42 | Docs | View more details | Give us feedback! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f1887a7b9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Keep credentials as P0; treat request-body/query/PII as Ask First. Flag Time.now in shipped code or specs. Merge the core skill-copy sync.
Use the current platform SHA for the GitLab include and the job clone.
Bring in the master merge so the stacked overrides PR stays current.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0c51c34019
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
LLM ValidationLLM Validation Gate — dd-apm-sdk-review✅ PASS
AnalysisChanged instruction file(s): No safety or blocking-case regressions across 1 case(s). Overall pairwise win-rate 75% [51%–99%], quality +4.6 — see the verdict above for whether that clears the noise band. Results
Per-dimension scores, token usage, latency, and estimated cost are in the CI job logs. |
Keep the stacked overrides branch on the latest verbatim skill copy.
…NTS.md Give the ENV/Time.now fixture a lib/ path and include AGENTS.md in the case files and the monitored instruction list, matching the JS pattern.
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Keep the stacked overrides branch on the latest verbatim skill copy.
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@codex based on best practices described here |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e186296a35
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex security covers that lane. Local skill runs on demand; GitHub Codex follows review-without-harness.md.
Drop the redundant ENV addendum (EnvUsageCop already owns lib/), keep Time.now on lib/**/*.rb, and exclude .agents/.llm-validation from the packaged gem.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4dbc2b0dae
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Take the verbatim skill from the copy so the stacked PR no longer conflicts on SKILL.md / reviewers.
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
RFC-style emphasis so the conventions reviewer treats the ENV/Time.now carve-out as a hard MUST NOT, not casual English. Co-authored-by: Cursor <cursoragent@cursor.com>
Recurring code-review theme observed across multiple independent PRs in the last 60 days (e.g. #6278 "Always use Datadog::Core::Utils::Time.now", plus review comments on #6307 codifying the convention): direct `Time.now` calls in library code should be replaced with `Datadog::Core::Utils::Time.now`, which captures the original (non-monkey-patched) implementation once at load time so it is not affected by test tools like Timecop and is safe to call from any thread. Mirrors the structure of the existing CustomCops::EnvUsageCop.
This branch has not been deployed
3 participants
What does this PR do?
Adds the dd-trace-rb layer on top of the shared skill copy.
.agents/dd-apm-sdk-review-overrides/— Ruby reviewer facts (conventions, security, repo context)AGENTS.md— short hook: local agents run the skill; Codex readsreview-without-harness.md.llm-validation/— cases that exercise those rules, plus the GitLab"llm validation"includeStacked on the core-copy PR. Shared skill source: dd-apm-sdk-review-core#1.
Motivation
This is the half of #6301 that Ruby reviewers should actually read.
Additional Notes
How to review
.agents/dd-apm-sdk-review-overrides/AGENTS.mdReview Guidelines block.llm-validation/if you care about the gate.agents/skills/dd-apm-sdk-review/— that is the parent PR / core repoMerge with the parent skill-copy PR, not as a standalone.
Change log entry
None.
Made with Cursor