test(java): enable ot.th/ot.rv tracestate sampling scenarios [java@milan.garnier/ot.th]

[MilanGarnier]

Motivation

Enable the shared OpenTelemetry consistent tracestate sampling coverage for Java once dd-trace-java#12397 is available.

Changes

• Activate the parametric OTel tracestate sampling suite.
• Activate all e2e OTel tracestate sampling classes.

[github-actions]

CODEOWNERS have been resolved as:

manifests/java.yml                                                      @DataDog/system-tests-reviewers

[datadog-datadog-prod-us1-2]

 

✨ Unblock PR with BitsAI

⚠️ Warnings

❌ Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 17 Pipeline jobs failed

Testing the test | System Tests (java, dev) / End-to-end #1 / akka-http 1 — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

Declared version 1.67.0 exceeds current version 1.67.0-SNAPSHOT+629892d492 in multiple test cases in tests/test_otel_tracestate_sampling.py.

Testing the test | System Tests (java, dev) / End-to-end #1 / jersey-grizzly2 1 — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

Manifest declares versions ahead of the current tested version in multiple tests: declared version 1.67.0 exceeds current version 1.67.0-SNAPSHOT+629892d492.

Testing the test | System Tests (java, dev) / End-to-end #1 / play 1 — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

Declared version 1.67.0 exceeds current version 1.67.0-SNAPSHOT+629892d492 across multiple tests in test_otel_tracestate_sampling.py.

View all 17 failed jobs.

📋 Copy fix prompt

CI on my pull request is failing. Help me find and fix the root cause of each failing job below — they were flagged as caused by changes in this PR, so focus on the diff. For each job, explain the failure and propose a fix.

Before you start, set up the Datadog software-delivery tooling so you can
query the CI data yourself:

1. Check whether you already have the Datadog software-delivery MCP tools
   (e.g. a `search_datadog_ci_pipeline_events` tool) and the `unblock-pr` skill.
2. If either is missing, STOP and ask me for permission before installing
   anything. Do not install or run anything until I have said yes.
3. Only with my explicit approval, set up the Datadog software-delivery MCP
   server and skills by following:
     https://docs.datadoghq.com/getting_started/software_delivery_mcp_tools/
   then restart so the skill is picked up.
4. If I decline, skip all of the above and work from the context below alone.

Then run /unblock-pr — it will pull the CI data itself. The job context below is what we already know.

If /unblock-pr is not available — because I declined the setup above, or it did not install — work from the context below instead.

Datadog has already classified this failure as caused by changes in this PR.
Take that as given and work the fix:

1. Locate the change. Diff this branch against its base and find the change
   that produces this error. Explain the mechanism, don't just name a file:
     git fetch origin && git diff $(git merge-base origin/main HEAD)...HEAD
2. Reproduce it locally. Run the failing job's command or test before
   proposing anything.
3. Propose the smallest fix that addresses the root cause — not a workaround,
   not a broadened assertion, not a disabled or skipped test.
4. Re-run the same command to confirm, and say exactly what you ran.
5. If the failure turns out to be intermittent rather than deterministic, say
   so plainly instead of "fixing" it — that is a flaky test, and patching it
   hides the problem.

If the right move is to re-run the job rather than change code, use the job
link in the context below. For GitHub Actions: `gh run rerun <run-id> --failed`,
where the run ID is the number after `/runs/` in that URL (not the trailing
number, which is the job ID).

Branch: milan.garnier/enable-otel-th-rv-java-manifest

Testing the test | System Tests (java, dev) / End-to-end #1 / akka-http 1
Commit: 4d92d1c7d15ce6a87e9c82e65d866499bf0f8232
Error (code / build):
Declared version 1.67.0 exceeds current version 1.67.0-SNAPSHOT+629892d492 in multiple test cases in tests/test_otel_tracestate_sampling.py.
CI job: https://github.com/DataDog/system-tests/actions/runs/34462999512/job/102828375470

Testing the test | System Tests (java, dev) / End-to-end #1 / jersey-grizzly2 1
Commit: 4d92d1c7d15ce6a87e9c82e65d866499bf0f8232
Error (code / build):
Manifest declares versions ahead of the current tested version in multiple tests: declared version 1.67.0 exceeds current version 1.67.0-SNAPSHOT+629892d492.
CI job: https://github.com/DataDog/system-tests/actions/runs/34462999512/job/102828375762

Testing the test | System Tests (java, dev) / End-to-end #1 / play 1
Commit: 4d92d1c7d15ce6a87e9c82e65d866499bf0f8232
Error (code / build):
Declared version 1.67.0 exceeds current version 1.67.0-SNAPSHOT+629892d492 across multiple tests in test_otel_tracestate_sampling.py.
CI job: https://github.com/DataDog/system-tests/actions/runs/34462999512/job/102828375647

Plus 13 more failing jobs not shown here.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c37b3ec | Docs | View more details | Give us feedback!}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c37b3ecbef

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Include the 1.67.0 snapshot builds in the activation range

When CI runs these tests against the Java 1.67 development/PR build, whose version is reported as 1.67.0-SNAPSHOT~<sha>, this v1.67.0 condition does not match because the snapshot is semantically earlier than the stable 1.67.0 release (the Java normalization behavior is covered in tests/test_the_test/test_version.py:170-173). Consequently, the parametric suite and all ten similarly changed end-to-end classes remain skipped while validating the implementation branch; use a snapshot-inclusive lower bound such as v1.67.0-SNAPSHOT. .cursor/rules/test-activation.mdcL159-L164

Useful? React with 👍 / 👎.

[chatgpt-codex-connector]

Preserve incomplete-app skips for unsupported weblogs

When Test_ForceKeepClearsTh runs on akka-http, jersey-grizzly2, ratpack, resteasy-netty3, or spring-boot-3-native, its inherited-rv assertions cannot pass because the class reads injected downstream headers from /trace/manual_keep_drop (tests/test_otel_tracestate_sampling.py:338-376), while the existing declaration at manifests/java.yml:4904-4910 explicitly records that this endpoint cannot report those headers on these five weblogs. Activating the class unconditionally therefore turns a known test-app limitation into failures once the version gate matches; retain weblog-specific incomplete_test_app declarations for these variants. .cursor/rules/test-activation.mdcL22-L31

Useful? React with 👍 / 👎.