Skip to content

fix(php): profiling marker checks - #7658

Open
morrisonlevi wants to merge 4 commits into
mainfrom
levi/common-extension-2
Open

fix(php): profiling marker checks#7658
morrisonlevi wants to merge 4 commits into
mainfrom
levi/common-extension-2

Conversation

@morrisonlevi

@morrisonlevi morrisonlevi commented Sep 4, 2026

Copy link
Copy Markdown

Motivation

I'm merging the PHP profiler into the ddtrace.so artifact, meaning there will be no separate datadog-profiling.so artifact anymore once that PR merges.

Changes

Changes the check to work for the old and new setup alike. This way it can be merged before the other PR is merged.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

utils/build/docker/php/common/install_ddtrace.sh                        @DataDog/system-tests-reviewers

@morrisonlevi
morrisonlevi marked this pull request as ready for review September 8, 2026 14:00
@morrisonlevi
morrisonlevi requested a review from a team as a code owner September 8, 2026 14:00
@morrisonlevi
morrisonlevi requested review from cecile75 and removed request for a team September 8, 2026 14:00
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-08T14:06:20.918733Z 0ad5ac5 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Sep 8, 2026

Copy link
Copy Markdown

Tests

All CI checks and tests passed.

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ab109b3 | Docs | View more details | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant