Skip to content

test(otel): cover OTEL_RESOURCE_ATTRIBUTES parametrically - #7678

Merged
MilanGarnier merged 4 commits into
mainfrom
milan.garnier/test-otel-resource-attributes
Sep 17, 2026
Merged

MilanGarnier merged 4 commits into
mainfrom
milan.garnier/test-otel-resource-attributes

Conversation

@MilanGarnier

Copy link
Copy Markdown
Contributor

Summary

  • add dedicated parametric coverage for OTEL_RESOURCE_ATTRIBUTES
  • cover stable values, unset and empty values, malformed input, percent-encoded
    separators, and reserved attribute mappings
  • activate supported tracers from registry version boundaries and track known
    parser gaps with language-specific Jira tickets

Tracking

  • implementation: APMAPI-2399
  • percent-decoding gaps: APMAPI-2421
  • malformed-list gaps: APMAPI-2422
  • PHP malformed-input crash: APMAPI-2423

Validation

  • ./format.sh
  • focused parametric matrix on .NET, Go, Java, Node.js, PHP, Python, Ruby,
    and Rust

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

tests/parametric/otel_env_vars/test_otel_resource_attributes.py         @DataDog/system-tests-reviewers
manifests/cpp.yml                                                       @DataDog/system-tests-reviewers
manifests/dotnet.yml                                                    @DataDog/system-tests-reviewers
manifests/golang.yml                                                    @DataDog/system-tests-reviewers
manifests/java.yml                                                      @DataDog/system-tests-reviewers
manifests/nodejs.yml                                                    @DataDog/system-tests-reviewers
manifests/php.yml                                                       @DataDog/system-tests-reviewers
manifests/python.yml                                                    @DataDog/system-tests-reviewers
manifests/ruby.yml                                                      @DataDog/system-tests-reviewers
manifests/rust.yml                                                      @DataDog/system-tests-reviewers
tests/parametric/test_otel_env_vars.py                                  @DataDog/system-tests-reviewers

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Sep 8, 2026

Copy link
Copy Markdown

Tests

All CI checks and tests passed.

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 19e5120 | Docs | View more details | Give us feedback!

@MilanGarnier
MilanGarnier marked this pull request as ready for review September 10, 2026 16:18
@MilanGarnier
MilanGarnier requested review from a team as code owners September 10, 2026 16:18
@MilanGarnier
MilanGarnier requested review from mhlidd and removed request for a team September 10, 2026 16:18

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4c4e095013

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread tests/parametric/otel_env_vars/test_otel_resource_attributes.py
Comment thread tests/parametric/otel_env_vars/test_otel_resource_attributes.py
Comment thread tests/parametric/otel_env_vars/test_otel_resource_attributes.py
Comment thread tests/parametric/otel_env_vars/test_otel_resource_attributes.py

@mhlidd mhlidd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread tests/parametric/otel_env_vars/test_otel_resource_attributes.py
Comment thread tests/parametric/otel_env_vars/test_otel_resource_attributes.py Outdated

@mhlidd mhlidd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…el-resource-attributes

# Conflicts:
#	manifests/rust.yml
#	tests/parametric/test_otel_env_vars.py
@gh-worker-ownership-write-b05516
gh-worker-ownership-write-b05516 Bot removed the request for review from a team September 17, 2026 09:16
@MilanGarnier
MilanGarnier enabled auto-merge (squash) September 17, 2026 10:05
@MilanGarnier
MilanGarnier merged commit e0173ce into main Sep 17, 2026
435 checks passed
@MilanGarnier
MilanGarnier deleted the milan.garnier/test-otel-resource-attributes branch September 17, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants