Skip to content

[nodejs] Add live debugger guardrail fixtures - #7700

Draft
watson wants to merge 1 commit into
mainfrom
watson/DEBUG-6081/live-debugger-guardrails
Draft

[nodejs] Add live debugger guardrail fixtures#7700
watson wants to merge 1 commit into
mainfrom
watson/DEBUG-6081/live-debugger-guardrails

Conversation

@watson

@watson watson commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Motivation

The Node.js tracer guardrail work for DEBUG-6081 needs matching system-test fixtures and stable inputs for its budget and timeout behavior.

Changes

  • add the /debugger/budgets/:loops fixture to the Node.js Express, TypeScript Express, and Fastify weblogs
  • add the Node.js source-line mapping used by line-probe budget tests
  • increase the collection-filter input so optimized runtimes reliably exceed the evaluation budget
  • update the shifted capture-timeout line mapping and endpoint documentation

Testing

Tested with the Node.js tracer stack tip watson/DEBUG-6081/evaluation-timeout pinned at b1d7c6c5ef3393214c7095afe65885933d44e046.

  • DEBUGGER_PROBES_SNAPSHOT: 4 passed
    • line-probe budgets
    • line-probe capture-expression budgets
    • regex evaluation timeout
    • collection-filter evaluation timeout
  • DEBUGGER_CAPTURE_TIMEOUT: 1 passed

Related tracer PR: DataDog/dd-trace-js#10156

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

docs/understand/weblogs/end-to-end_weblog.md                            @DataDog/system-tests-core
tests/debugger/test_debugger_guardrails.py                              @DataDog/debugger
tests/debugger/utils.py                                                 @DataDog/debugger
utils/build/docker/nodejs/express/debugger/index.js                     @DataDog/system-tests-reviewers
utils/build/docker/nodejs/express4-typescript/debugger/index.ts         @DataDog/system-tests-reviewers
utils/build/docker/nodejs/fastify/debugger/index.js                     @DataDog/system-tests-reviewers

@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Sep 11, 2026

Copy link
Copy Markdown

Pipelines  Tests

⚠️ Warnings

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 2 Pipeline jobs failed

Testing the test | System Tests (python, prod) / End-to-end #1 / python3.12 1 — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

Testing the test | all-jobs-are-green

View more details · View in GitHub Actions

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 3f71984 | Docs | View more details | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant