Adds set_state support for left and modified left eigenvectors - #335
Open
benjaminhyatt wants to merge 1 commit into
Open
Adds set_state support for left and modified left eigenvectors#335benjaminhyatt wants to merge 1 commit into
benjaminhyatt wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small PR that allows you to pass one of two new optional input arguments (set_left and set_modified_left) to solver.set_state in order to set a field to a left or modified left eigenmode, respectively. The default behavior when neither are specified (i.e., they are both False) remains the same as before: returning a mode of a given index in solver.eigenvectors = solver.right_eigenvectors.
I have been using this recently (particularly set_state with set_modified_left=True) in order to form a biorthogonal set of Rossby wave eigenmodes in a DiskBasis setup, and it appears to be working as intended.