PivotGrid - KBN - Implement arrow navigation for area fields#34259
Merged
aleksei-semikozov merged 6 commits intoJul 13, 2026
Merged
Conversation
aleksei-semikozov
force-pushed
the
pivotgrid-kbn-fields-arrow-navigation
branch
from
4ff3e29 to
84111ab
Compare
aleksei-semikozov
force-pushed
the
pivotgrid-kbn-fields-arrow-navigation
branch
from
27d1fa2 to
21dcad3
Compare
sjbur
approved these changes
Jul 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds roving-tabindex + arrow-key navigation for PivotGrid/FieldChooser area fields to improve keyboard navigation (KBN) behavior and updates end-to-end coverage accordingly.
Changes:
- Introduces per-area roving tabindex management and Arrow key navigation for area fields in
FieldChooserBase. - Ensures FieldChooser updates field tab indexes after rendering.
- Updates TestCafe KBN tests to validate “single tab stop per area” and Arrow-key navigation, and adjusts Tab traversal expectations.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/pivot_grid/field_chooser/m_field_chooser.ts | Triggers field tab index normalization after FieldChooser content render. |
| packages/devextreme/js/__internal/grids/pivot_grid/field_chooser/m_field_chooser_base.ts | Implements roving tabindex per area + Arrow navigation; hooks focus tracking into roving state. |
| e2e/testcafe-devextreme/tests/common/pivotGrid/kbn/fields.ts | Extends KBN e2e tests for roving tabindex (single tab stop) and Arrow navigation; updates Tab traversal steps. |
Comment on lines
+166
to
+169
| // Field indexes are only meaningful within one data source, so the roving | ||
| // tab stops fall back to the first field of each area. | ||
| this._resetFieldNavigation(); | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.