Skip to content

fix(ui): sanitize external quicklink URLs#352

Open
cavidelizade wants to merge 1 commit into
Devlaner:mainfrom
cavidelizade:fix/quicklink-safeurl
Open

fix(ui): sanitize external quicklink URLs#352
cavidelizade wants to merge 1 commit into
Devlaner:mainfrom
cavidelizade:fix/quicklink-safeurl

Conversation

@cavidelizade

Copy link
Copy Markdown
Contributor

Summary

The home page rendered a quicklink's stored URL straight into the anchor href, so a javascript: URL would run when someone clicked the link.

Linked issues

Closes #327

Type of change

  • Bug fix (fix:)

Surface

  • UI (apps/web/)

What changed

WorkspaceHomePage.tsx: the external quicklink href now goes through safeUrl (the same helper every other link surface uses), which only allows http/https/mailto. The favicon, copy and open-in-new-tab paths already used a helper that forced an https:// prefix, so only the clickable anchor was exposed.

Test plan

  • npm run typecheck + npm run lint pass
  • Manual: a quicklink saved with javascript:... now resolves to a dead # instead of running

AI assistance

  • AI tools were used, tool(s): Claude Code (Opus 4.8), commits carry a Co-Authored-By: trailer

The home page rendered a quicklink's stored URL straight into the anchor href,
so a javascript: URL would run when clicked. Every other link surface already
runs through safeUrl; the quicklink anchor was the exception (the favicon, copy
and open-in-new-tab paths were fine). Route the external href through safeUrl
so only http/https/mailto get through.

Closes Devlaner#327

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@cavidelizade
cavidelizade requested a review from a team as a code owner July 16, 2026 20:08
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@cavidelizade, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 08b93ed3-fa11-4f90-b773-71b40694d72f

📥 Commits

Reviewing files that changed from the base of the PR and between 61bc903 and 0572bd5.

📒 Files selected for processing (1)
  • apps/web/src/pages/WorkspaceHomePage.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quicklink URLs are rendered without sanitization (javascript: XSS)

1 participant