Skip to content

fix(api): create a workspace and its owner membership atomically#363

Open
cavidelizade wants to merge 1 commit into
Devlaner:mainfrom
cavidelizade:fix/workspace-create-atomic
Open

fix(api): create a workspace and its owner membership atomically#363
cavidelizade wants to merge 1 commit into
Devlaner:mainfrom
cavidelizade:fix/workspace-create-atomic

Conversation

@cavidelizade

Copy link
Copy Markdown
Contributor

Summary

Creating a workspace wasn't atomic and the "add owner as member" error was discarded. If that second write failed, the workspace existed with no members, and since access is gated on membership the owner was locked out of the workspace they just created.

Linked issues

Closes #340

Type of change

  • Bug fix (fix:)

Surface

  • API (apps/api/)

What changed

Added WorkspaceStore.CreateWithOwner, which inserts the workspace and the owner membership in a single transaction, and switched the service to it. This mirrors ProjectStore.CreateWithCreatorMember, which already does the same thing. Also replaced the magic Role: 20 with model.RoleOwner.

Test plan

  • go build, go vet, go test ./... green

AI assistance

  • AI tools were used, tool(s): Claude Code (Opus 4.8), commits carry a Co-Authored-By: trailer

WorkspaceService.Create inserted the workspace, then added the owner membership
in a separate statement and discarded the error. If that second write failed,
the workspace existed with no members, and since access is gated on membership
the owner was locked out of the workspace they just created, with no way to
clean it up from the UI.

Add WorkspaceStore.CreateWithOwner, which does both writes in one transaction
(mirrors ProjectStore.CreateWithCreatorMember), and use it from the service.

Closes Devlaner#340

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@cavidelizade
cavidelizade requested a review from a team as a code owner July 16, 2026 21:02
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@cavidelizade, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 3 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b8b8bea9-7786-4746-9c30-a4b5969e2b0e

📥 Commits

Reviewing files that changed from the base of the PR and between 61bc903 and a52e394.

📒 Files selected for processing (2)
  • apps/api/internal/service/workspace.go
  • apps/api/internal/store/workspace.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workspace creation isn't atomic and can lock the owner out

1 participant