Cameraz - #156
Merged
Merged
Cameraz#156
Conversation
…ers (temporary to common/include/camera directory)
…ific range type & projection matrix type constraints, update ILinearProjection and CCubeProjection - now I can pair IProjection with a gimbal
…urces, save main.cpp tests, add TODO comments
…s with abstract manipulate method - expect virtual event & a gimbal. Update CGimbal with new manipulation & set methods, start replacing CCamera content with new gimbal & controller
…from CCamera, mark TODOs for tomorrow
… tomorrow - make CCamera use gimbal & treat as FPS controller
…tion with isLeftHanded method, update sources & some of matrices to HLSL - the pure virtual controller manipulate method now takes a gimbal + span of virtual events
…h a setter & get with a getter therefore determine at set time handness (compute determinant only once after the matrix gets changed!), update main.cpp & sources - time to test it
…tance virtual, init time stamps with defaults
…tation (TODO: constraints for type of camera + I broke continuity of events signaling & need those keysPressed bools I guess)
Comment on lines
+29
to
+30
| virtual void manipulate(std::span<const typename traits_t::controller_virtual_event_t> virtualEvents) override | ||
| { |
Member
Author
There was a problem hiding this comment.
I guess CCamera needs to be called a CFPSCamera then?
# Conflicts: # 09_GeometryCreator/main.cpp # 12_MeshLoaders/main.cpp # 50.IESViewer/AppInit.cpp # 50.IESViewer/AppRender.cpp # 50.IESViewer/AppUI.cpp # 61_UI/main.cpp # 70_FLIPFluids/main.cpp # 73_GeometryInspector/main.cpp # common/include/nbl/examples/cameras/CCamera.hpp
…undant math util functions, consistent matrix conventions (mat4x4 vs new CameraBasis).
- notes: from my perspective this example isn't worth the maintanance, a huge application of it's own, had it's fair share of problems. so I asked AI in this commit to fix things to match the new camera extension changes and I did very minimal review unlike always. So I'm embarassed for this commit, I had limited choice and I have more important things to get into. I think it was better than deprecating or removing it from CI, but it's not essential code fortunately. maintaining this example woule take weeks from a juniordev. it has too many cons and too little pros.
…e guard to consumedEvents overflow detection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes 61_UI consume Nabla::ext::Cameras as a downstream example and harness.