feat: prepare external API persistence foundation - #750
Open
bballdavis wants to merge 6 commits into
Open
bballdavis wants to merge 6 commits into
bballdavis wants to merge 6 commits into
Conversation
bballdavis
marked this pull request as ready for review
August 8, 2026 19:55
bballdavis
force-pushed
the
feature/external-api-foundation
branch
from
September 8, 2026 19:50
65924e4 to
40a84e7
Compare
This was referenced Sep 8, 2026
bballdavis
force-pushed
the
feature/external-api-foundation
branch
from
September 8, 2026 23:22
e67e7f0 to
fd24c14
Compare
dialmaster
requested changes
Sep 13, 2026
dialmaster
left a comment
Collaborator
There was a problem hiding this comment.
The main blockers for this PR (see my other comments):
- the global brace-expansion override breaks minimatch
- the channel dedupe migration can leave an install unable to start
- the eight 20260726 no-op migrations need to go
- squashing the migrations together (eg, no need for multiple migrations for the same new table)
bballdavis
force-pushed
the
feature/external-api-foundation
branch
from
September 15, 2026 02:44
27ba03e to
c5ed12d
Compare
bballdavis
force-pushed
the
feature/external-api-foundation
branch
from
September 15, 2026 03:44
c5ed12d to
e2d0a7f
Compare
dialmaster
requested changes
Sep 18, 2026
dialmaster
left a comment
Collaborator
There was a problem hiding this comment.
See my comment on line 23 of migrations/20260908100000-add-external-api-key-policy.js, just one last minor thing and then I think this will be good to approve :)
dialmaster
requested changes
Sep 26, 2026
bballdavis
added a commit
to bballdavis/Youtarr
that referenced
this pull request
Sep 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #568.
Scope boundaries
This phase exposes no external routes, authentication middleware, request execution, management endpoints, rate-limit enforcement, feature flags, Swagger contract, or frontend UI.
Migration safety
Validation
5358ac1bpackage.jsonadds only the dedicated database test script;package-lock.jsonremains aligned with current dev