Conversation
ci: update appveyor files
fix: correct path to vsdevcmd.bat for VS2015
Set compiler name for windows
Dikluwe
force-pushed
the
fix/sonodekitpath-object-model-safety
branch
from
September 16, 2026 19:57
cd9e740 to
f3c72da
Compare
Owner
Author
|
Superseded by coin3d#747. The branch was rebased directly onto upstream master and the SoNodeKitPath fix is now independent from coin3d#714, so this stacked fork-only draft is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
SoNodeKitPath was used as an interface lens over storage created as SoPath. Unlike a valid base-to-derived relationship, the dynamic object was never a SoNodeKitPath; calling derived members through that pointer is undefined behavior and UBSan/vptr detects it. PR coin3d#714 fixes the analogous SoFullPath pattern and supplies the full-route accessors used by this follow-up.
This PR preserves the Open Inventor-facing projection while restoring a real C++ object model: objects returned as SoNodeKitPath* are now actually constructed as SoNodeKitPath.
Validation
Compatibility
The public nodekit projection remains intact. This is stacked on coin3d#714 because it depends on the new full-path accessors and must not be reviewed as a duplicate of that PR.