Repository navigation
feat(footer): credit Recurssive at the foot of the footer - #1136
Merged
Merged
Conversation
"Developed and designed by Recurssive", with the Reflow mark, linking to recurssive.com. Inkweave's own copy of Recurssive's shared footer credit, restyled with Inkweave's tokens (owner, 2026-11-05) so it needs no exemption from the design-token rules: textMuted at rest, text on hover, and the mark turns the brand gold. rel="nofollow", since the link repeats in the footer of every page. Committed with --no-verify (owner-approved): on Windows the pre-commit suite fails 28 binder-shelf tests on master as well, from BinderShelf.tsx and binderShelf.ts sharing a name on a case-insensitive filesystem.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
size-limit report 📦
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…us, use DURATION Review fixes on the Recurssive credit: - The mark sets width 1.5em beside height 1em, from the 120x80 viewBox, instead of width auto, which WebKit can size at its 300px default as an inline SVG flex item. - Keyboard focus lights the credit as hover does (text, gold mark). - The two transitions read DURATION.fast instead of a literal 0.15s. - The mark's coordinates are rounded to one decimal by script (about 0.01px at the footer's 10px), trimming about 100 bytes gzipped. Committed with --no-verify (owner-approved), for the Windows-only binder-shelf clash described in 5823eb7.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…its comment The credit stands alone on the footer's last row, not inside a sentence, so its 10px line was its whole tap area, under WCAG 2.5.8's 24px. minHeight TOUCH_TARGET makes it 44px tall; the footer grows 32px. The header comment states the hand-kept copy's constraint without the history CLAUDE.md asks comments to leave out. Committed with --no-verify (owner-approved), for the Windows-only binder-shelf clash described in 5823eb7.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Fix all with cubic | Re-trigger cubic
A click's focus outlasts the click: the link opens a new tab, and focus is still on it on the way back, which left the credit lit. onFocus now reads focusedByKeyboard (:focus-visible), as CollectionSetPanel does. Committed with --no-verify (owner-approved for #1136), for the Windows-only binder-shelf clash described in 5823eb7.
There was a problem hiding this comment.
Gates Passed
See analysis details in CodeScene
Quality Gate Profile: Pay Down Tech Debt
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
The site footer now ends with a studio credit: the Reflow mark and "Developed and designed by Recurssive", linking to recurssive.com. It sits centred under the Ravensburger notice, at the footer's
FONT_SIZES.xs.apps/web/src/shared/components/RecurssiveCredit.tsxis Inkweave's own copy of Recurssive's shared footer credit, its plain variant.COLORS.textMutedlike the footer's links. On hover the text lifts toCOLORS.textand the mark turnsCOLORS.primary, throughuseHoverasLinkButtondoes.rel="noopener nofollow": it repeats in the footer of every page, and Google lists "widely distributed links in the footers or templates of various sites" under link spam.RecurssiveCredit.stories.tsxis its story, forcheck:stories.Footer.tsxrenders it as the footer's last line.Hooks skipped (owner-approved)
Both the commit and the push used
--no-verify. On Windows, master's own suite fails here:tsc -bstops with 8 errors.BinderShelf.test.tsxanduseBrowseCollection.test.tsx.Both come from
binders/BinderShelf.tsxandbinders/binderShelf.tsdiffering only in letter case, which a case-insensitive filesystem can't tell apart. The same two test files fail with this change set aside. CI on Linux is the first full run of typecheck, E2E and CodeScene on this change.Verification
Run on Windows:
inkweave/*rules),check:design,check:storiesandknippass for these files. Knip's two unused files are the binder-shelf pair, already on master.CardPage.test.tsx, the test that renders the Footer, passes./aboutat desktop width, the credit is centred and hasrel="noopener nofollow",textMuted, 10px. Hovering givestextand a#ffb900mark./at 375px, it's the footer's last line, with nothing fixed covering it.Summary by cubic
Adds a studio credit at the foot of the site footer: the Reflow mark and "Developed and designed by Recurssive", linking to recurssive.com.
textMutedat rest,textwith a brand-gold mark on hover or keyboard focus) so it passes the design-token rules without an exemption.minHeightisTOUCH_TARGET(44px), since its 10px line alone was under WCAG 2.5.8's 24px minimum; the footer grows 32px.1.5em×1em), since WebKit can scale an inline SVG flex item to its 300px default atwidth: auto.rel="noopener nofollow", since it repeats in the footer of every page.Note on verification
Both the commit and push used
--no-verify(owner-approved): on Windows, master's own suite fails to typecheck and 28 tests fail inBinderShelf.test.tsxanduseBrowseCollection.test.tsx, caused bybinders/BinderShelf.tsxandbinders/binderShelf.tsdiffering only in letter case on a case-insensitive filesystem. The same failures occur with this change set aside.Written for commit 15ce13c. Summary will update on new commits.