fix(vmm): keep Host API on the private vsock listener - #861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
VMM could expose the Host API on a general/public vsock listener after listener setup was refactored. That crossed the intended trust boundary: guest-facing peers could reach host-management RPCs.
Root cause and fix
Keep Host API routing attached only to the private vsock listener and leave the public listener with its intended guest surface.
Implementation
The branch records the following focused implementation work:
fix(vmm): keep Host API on private vsock listenerChanged paths:
dstack/vmm/src/main.rsScope
This PR addresses one logical
vmmfinding. It intentionally excludes the acceptance-test infrastructure from #841 and unrelated product fixes from #840.Dependency and merge order
This PR is based directly on
masterand does not require another split product PR to merge first.Verification
git diff --check origin/master..origin/codex/fix-vmm-private-host-api: passed.