[STACKED on #863] fix(kms): make Bootstrap one-time - #873
Merged
Conversation
This was referenced Jul 31, 2026
Defect: sequential and concurrent Onboard.Bootstrap requests could regenerate and overwrite an initialized KMS hierarchy. Observed symptom: repeated requests returned HTTP 200, changed persisted key metadata, and could leave certificates inconsistent. Fix: serialize Bootstrap within the service and reject any request after bootstrap state or root keys exist.
kvinwang
force-pushed
the
codex/fix-kms-bootstrap-once
branch
from
August 3, 2026 14:53
449142d to
0aabeec
Compare
kvinwang
added a commit
that referenced
this pull request
Aug 4, 2026
…missions [STACKED on #873] fix(kms): persist private keys owner-only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Bootstrap RPC remained callable after KMS had already initialized its root state. Replaying it could replace or diverge bootstrap material that all later certificates and keys depend on.
Root cause and fix
Persist a bootstrapped marker/state check and reject every Bootstrap call after the first successful initialization.
Implementation
The branch records the following focused implementation work:
fix(kms): make Bootstrap one-timeChanged paths:
dstack/kms/src/onboard_service.rsScope
This PR addresses one logical
kmsfinding. It intentionally excludes the acceptance-test infrastructure from #841 and unrelated product fixes from #840.Dependency and merge order
codex/fix-kms-onboarding-domainsVerification
git diff --check origin/codex/fix-kms-onboarding-domains..origin/codex/fix-kms-bootstrap-once: passed.