refactor(buildcontext): unify Earthfile parsing into single pass and … - #799
Draft
janishorsts wants to merge 1 commit into
Draft
refactor(buildcontext): unify Earthfile parsing into single pass and …#799janishorsts wants to merge 1 commit into
janishorsts wants to merge 1 commit into
Conversation
…remove redundant parseCache
➖ Are we earthbuild yet?No change in "earthly" occurrences 📈 Overall Progress
Keep up the great work migrating from Earthly to Earthbuild! 🚀 💡 Tips for finding more occurrencesRun locally to see detailed breakdown: ./.github/scripts/count-earthly.shNote that the goal is not to reach 0. |
janishorsts
marked this pull request as ready for review
August 11, 2026 11:26
janishorsts
marked this pull request as draft
August 12, 2026 09:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, resolving an Earthfile required parsing the file twice: once through
ParseVersion(viaparseFeatures) to inspect feature flags, and later throughearthfile.ParseFileto construct the AST. To bridge these separate passes,Resolvermaintained its ownparseCachealongside the existingbuildFileCache.Caching parsed ASTs to avoid re-parsing files that were already being cached by the resolver was an unnecessary layer of indirection.
This change unifies Earthfile parsing into a single pass:
newEarthfileBuildreads and parses the Earthfile into its full AST (earthfile.Tree) up front.tree.Version, processed for warnings, and merged with CLI overrides.buildFilestruct carries both the feature configuration and the AST tree.parseFeatures.go,version.go, and the redundantparseCacheare removed.Parsing once and holding the result simplifies control flow, removes ~320 lines of redundant parsing logic, and keeps resolver caching in one clear place.