feat: Add PR title linting - #299
Conversation
Szelethus
left a comment
There was a problem hiding this comment.
I understand this is tricky to test, so I'm inclined to commit and see how it works. The only concern I have is related to breaking changes/major releases.
According to https://github.com/amannn/action-semantic-pull-request,
Note that since pull request titles only have a single line, you have to use ! to indicate breaking changes.
and I wonder whether https://github.com/mathieudutour/github-tag-action will pick up on that. Also, I just fear for the transparency of the whole thing. It'd be great if we could forecast whether the PR will be regarded as a patch/minor/major release (for instance, through automatic labeling).
Another option would be to test on a dummy repo.
|
I'm testing it in a separate repo. I got this for a test PR: These are case-sensitive! The auto version increment picks up the |
Szelethus
left a comment
There was a problem hiding this comment.
i tried !feat: ... for a breaking change PR, the linting worked but the version bump couldn't handle this case.
While that is unfortunate, I think that is a tagging/versioning side fix anyways. I'm in favour of landing this now and ironing out kinks as they come.
Why:
We want to auto-tag every merged PR (maybe even auto-release). For this, we need PR titles (and maybe contents) to follow certain rules.
What:
Addresses:
#47