Repository navigation
Release response sockets on failed requests - #64
Merged
Merged
Conversation
Failed requests caused the CLI to hang due to an open socket. Release sockets on failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Failed registry requests caused the CLI (and likely other applications) to hang due to an open socket. FPL now properly releases sockets after a failed request.
Testing Instructions:
To test, run the following command on the
mainbranch and this branch:On the main branch, it will hang. On this branch the CLI will properly terminate after the failures.
Related Issue:
N/A